From caed3b169f1db94ba58d6e702e1ee90fcee7c6b4 Mon Sep 17 00:00:00 2001 From: kairat_kushaev Date: Thu, 21 Jan 2016 12:58:03 +0300 Subject: Fix default mutables for set_acls read_tenants, write_tenants parameters in set_acls method of glance_store/driver.Store have empty lists as default values. It is not recommended approach cause it can lead to some neat issues. Moreover, Swift store class rewrites this method and uses None as default values (which is right). So we need to follow this approach in base Store class. Change-Id: Ifa0f0c286dbb822b2d34d03978655d720bb109d4 --- glance_store/driver.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glance_store/driver.py b/glance_store/driver.py index bab94d8..899ff2c 100644 --- a/glance_store/driver.py +++ b/glance_store/driver.py @@ -154,8 +154,8 @@ class Store(capabilities.StoreCapability): """ raise NotImplementedError - def set_acls(self, location, public=False, read_tenants=[], - write_tenants=[], context=None): + def set_acls(self, location, public=False, read_tenants=None, + write_tenants=None, context=None): """ Sets the read and write access control list for an image in the backend store. -- cgit v1.2.1