diff options
| author | Kamil Dudka <kdudka@redhat.com> | 2015-07-15 22:57:43 +0200 |
|---|---|---|
| committer | Ben Skeggs <bskeggs@redhat.com> | 2015-07-27 18:31:47 +1000 |
| commit | aa82ab538d46666276bac97952970a337a4e8503 (patch) | |
| tree | f95feb1b3c6cc2bb4f93891733cba0c3548be0c5 /drm/nouveau/nvkm/subdev/instmem | |
| parent | 7b66bbc1956709d42a04128bc1b50bce838fbbd2 (diff) | |
| download | nouveau-aa82ab538d46666276bac97952970a337a4e8503.tar.gz | |
drm/nv04-nv40/instmem: protect access to priv->heap by mutex
This fixes the list_del corruption reported
at <https://bugzilla.redhat.com/1205985>.
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
Diffstat (limited to 'drm/nouveau/nvkm/subdev/instmem')
| -rw-r--r-- | drm/nouveau/nvkm/subdev/instmem/nv04.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drm/nouveau/nvkm/subdev/instmem/nv04.c b/drm/nouveau/nvkm/subdev/instmem/nv04.c index 80614f1b2..282143f49 100644 --- a/drm/nouveau/nvkm/subdev/instmem/nv04.c +++ b/drm/nouveau/nvkm/subdev/instmem/nv04.c @@ -50,7 +50,12 @@ nv04_instobj_dtor(struct nvkm_object *object) { struct nv04_instmem_priv *priv = (void *)nvkm_instmem(object); struct nv04_instobj_priv *node = (void *)object; + struct nvkm_subdev *subdev = (void *)priv; + + mutex_lock(&subdev->mutex); nvkm_mm_free(&priv->heap, &node->mem); + mutex_unlock(&subdev->mutex); + nvkm_instobj_destroy(&node->base); } @@ -62,6 +67,7 @@ nv04_instobj_ctor(struct nvkm_object *parent, struct nvkm_object *engine, struct nv04_instmem_priv *priv = (void *)nvkm_instmem(parent); struct nv04_instobj_priv *node; struct nvkm_instobj_args *args = data; + struct nvkm_subdev *subdev = (void *)priv; int ret; if (!args->align) @@ -72,8 +78,10 @@ nv04_instobj_ctor(struct nvkm_object *parent, struct nvkm_object *engine, if (ret) return ret; + mutex_lock(&subdev->mutex); ret = nvkm_mm_head(&priv->heap, 0, 1, args->size, args->size, args->align, &node->mem); + mutex_unlock(&subdev->mutex); if (ret) return ret; |