From b705b73e46193c7691be40b732330a49affacedb Mon Sep 17 00:00:00 2001 From: Gabriel Wicke Date: Thu, 25 Sep 2014 09:59:18 -0700 Subject: url: make query() consistent Match the behavior of the slow path by setting url.query to an empty object when the url contains no query, but query parsing is requested. Also add a test for this case, and update the documents to clearly reflect this behavior. Fixes: https://github.com/joyent/node/issues/8332 Reviewed-by: Trevor Norris --- lib/url.js | 3 +++ 1 file changed, 3 insertions(+) (limited to 'lib') diff --git a/lib/url.js b/lib/url.js index 4c0ef0102..646342420 100644 --- a/lib/url.js +++ b/lib/url.js @@ -136,6 +136,9 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) { } else { this.query = this.search.substr(1); } + } else if (parseQueryString) { + this.search = ''; + this.query = {}; } return this; } -- cgit v1.2.1