<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node.git/test, branch node-review</title>
<subtitle>github.com: joyent/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/'/>
<entry>
<title>test: fix error messages after v8 upgrade</title>
<updated>2014-10-16T17:47:55+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-10T22:18:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=b94a3f68978f88e31d7a0c52caf01b238d0cb355'/>
<id>b94a3f68978f88e31d7a0c52caf01b238d0cb355</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>streams: make setDefaultEncoding() throw</title>
<updated>2014-10-09T23:48:59+00:00</updated>
<author>
<name>Brian White</name>
<email>mscdex@mscdex.net</email>
</author>
<published>2014-10-09T20:07:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=874dd590cf385baa534556eadee0fa5c2f985519'/>
<id>874dd590cf385baa534556eadee0fa5c2f985519</id>
<content type='text'>
PR-URL: https://github.com/joyent/node/pull/8529
Fixes: f04f3a0 "streams: set default encoding for writable streams"
[trev.norris@gmail.com: update tests to check if throws]
Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/joyent/node/pull/8529
Fixes: f04f3a0 "streams: set default encoding for writable streams"
[trev.norris@gmail.com: update tests to check if throws]
Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: fix test-child-process-spawn-typeerror</title>
<updated>2014-10-09T16:38:17+00:00</updated>
<author>
<name>Alexis Campailla</name>
<email>alexis@janeasystems.com</email>
</author>
<published>2014-10-08T18:30:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=61dd74bc5dfbab6b4db50ea1dd1cc7b7d2867a30'/>
<id>61dd74bc5dfbab6b4db50ea1dd1cc7b7d2867a30</id>
<content type='text'>
You cannot spawn 'dir' on Windows because it's not an executable.  Also,
some people might have 'ls' on their path on Windows, so I changed
invalidCmd to something that's highly unlikely to exist.

Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
You cannot spawn 'dir' on Windows because it's not an executable.  Also,
some people might have 'ls' on their path on Windows, so I changed
invalidCmd to something that's highly unlikely to exist.

Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>crypto: createDiffieHellman throw for bad args</title>
<updated>2014-10-08T22:38:46+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2014-10-08T22:38:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=1a4a189578944f62b3dfb6f4fc8dabe20a7535ee'/>
<id>1a4a189578944f62b3dfb6f4fc8dabe20a7535ee</id>
<content type='text'>
Previously crypto.createDiffieHellman() would fail silently when a bad
argument was passed for prime/prime_length. Now throws TypeError.

Fixes: https://github.com/joyent/node/issues/8480
Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously crypto.createDiffieHellman() would fail silently when a bad
argument was passed for prime/prime_length. Now throws TypeError.

Fixes: https://github.com/joyent/node/issues/8480
Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: fix debug-signal-cluster after da update</title>
<updated>2014-10-08T11:44:40+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-08T10:35:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=d87480beb29b764ba37cd983b594ad25a406a4c7'/>
<id>d87480beb29b764ba37cd983b594ad25a406a4c7</id>
<content type='text'>
The cluster children are hitting breakpoint at `cluster.onread` and
hanging on a Semaphore wait now. This prevents them from disconnecting
gracefully. Considering that the test is checking different thing, the
cluster children needs to be force killed from the grand parent process.

Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The cluster children are hitting breakpoint at `cluster.onread` and
hanging on a Semaphore wait now. This prevents them from disconnecting
gracefully. Considering that the test is checking different thing, the
cluster children needs to be force killed from the grand parent process.

Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</pre>
</div>
</content>
</entry>
<entry>
<title>src, test: fixup after v8 update</title>
<updated>2014-10-08T11:44:40+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-08T10:34:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=685ac099e9d8085c363a51a15c718d160a6dcd5c'/>
<id>685ac099e9d8085c363a51a15c718d160a6dcd5c</id>
<content type='text'>
Because of behavior change of some V8 APIs (they mostly became more
    strict), following modules needed to be fixed:

* crypto: duplicate prototype methods are not allowed anymore
* contextify: some TryCatch trickery, the binding was using it
incorrectly
* util: maximum call stack error is now crashing in a different place

Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Because of behavior change of some V8 APIs (they mostly became more
    strict), following modules needed to be fixed:

* crypto: duplicate prototype methods are not allowed anymore
* contextify: some TryCatch trickery, the binding was using it
incorrectly
* util: maximum call stack error is now crashing in a different place

Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</pre>
</div>
</content>
</entry>
<entry>
<title>deps: re-implement debugger-agent</title>
<updated>2014-10-08T11:44:40+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-04T14:44:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=7a0cfe9b116c6b5d56f7412d6ea71f5a8d8440e2'/>
<id>7a0cfe9b116c6b5d56f7412d6ea71f5a8d8440e2</id>
<content type='text'>
Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: fix for testing openssl integrations</title>
<updated>2014-10-08T08:19:25+00:00</updated>
<author>
<name>Refael Ackermann</name>
<email>refack@gmail.com</email>
</author>
<published>2014-10-02T08:20:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=573e6afc090d9bf194aef307de4b4bfe59c5867f'/>
<id>573e6afc090d9bf194aef307de4b4bfe59c5867f</id>
<content type='text'>
Windows doesn't resolve ".." the way we expect it for symlinks and
junctions.

PR-URL: https://github.com/joyent/node/pull/8489
Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
Reviewed-by: Fedor Indutny &lt;fedor@indutny.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Windows doesn't resolve ".." the way we expect it for symlinks and
junctions.

PR-URL: https://github.com/joyent/node/pull/8489
Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
Reviewed-by: Fedor Indutny &lt;fedor@indutny.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>streams: set default encoding for writable streams</title>
<updated>2014-10-08T00:04:10+00:00</updated>
<author>
<name>Johnny Ray</name>
<email>http://johnnyray.me</email>
</author>
<published>2014-10-07T23:32:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=f04f3a0d012603fb7bbc3e1c05a5a6cd01ab4010'/>
<id>f04f3a0d012603fb7bbc3e1c05a5a6cd01ab4010</id>
<content type='text'>
Add API Writable#setDefaultEncoding().

PR-URL: https://github.com/joyent/node/pull/8483
Fixes: https://github.com/joyent/node/issues/7159
Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add API Writable#setDefaultEncoding().

PR-URL: https://github.com/joyent/node/pull/8483
Fixes: https://github.com/joyent/node/issues/7159
Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>url: fixed encoding for slash switching emulation.</title>
<updated>2014-10-07T00:25:25+00:00</updated>
<author>
<name>Evan Rutledge Borden</name>
<email>evan.borden@skedge.me</email>
</author>
<published>2014-09-26T15:59:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=640ad632e3bf04fe07fa2b9dc3ca940c2e8d0261'/>
<id>640ad632e3bf04fe07fa2b9dc3ca940c2e8d0261</id>
<content type='text'>
Fixes: https://github.com/joyent/node/issues/8458
Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
Reviewed-by: Chris Dickinson &lt;christopher.s.dickinson@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes: https://github.com/joyent/node/issues/8458
Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
Reviewed-by: Chris Dickinson &lt;christopher.s.dickinson@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
