delta/node.git/test/simple, branch node-review github.com: joyent/node.git streams: make setDefaultEncoding() throw 2014-10-09T23:48:59+00:00 Brian White mscdex@mscdex.net 2014-10-09T20:07:50+00:00 874dd590cf385baa534556eadee0fa5c2f985519 PR-URL: https://github.com/joyent/node/pull/8529 Fixes: f04f3a0 "streams: set default encoding for writable streams" [trev.norris@gmail.com: update tests to check if throws] Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
PR-URL: https://github.com/joyent/node/pull/8529
Fixes: f04f3a0 "streams: set default encoding for writable streams"
[trev.norris@gmail.com: update tests to check if throws]
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
test: fix test-child-process-spawn-typeerror 2014-10-09T16:38:17+00:00 Alexis Campailla alexis@janeasystems.com 2014-10-08T18:30:01+00:00 61dd74bc5dfbab6b4db50ea1dd1cc7b7d2867a30 You cannot spawn 'dir' on Windows because it's not an executable. Also, some people might have 'ls' on their path on Windows, so I changed invalidCmd to something that's highly unlikely to exist. Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
You cannot spawn 'dir' on Windows because it's not an executable.  Also,
some people might have 'ls' on their path on Windows, so I changed
invalidCmd to something that's highly unlikely to exist.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
crypto: createDiffieHellman throw for bad args 2014-10-08T22:38:46+00:00 Trevor Norris trev.norris@gmail.com 2014-10-08T22:38:46+00:00 1a4a189578944f62b3dfb6f4fc8dabe20a7535ee Previously crypto.createDiffieHellman() would fail silently when a bad argument was passed for prime/prime_length. Now throws TypeError. Fixes: https://github.com/joyent/node/issues/8480 Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
Previously crypto.createDiffieHellman() would fail silently when a bad
argument was passed for prime/prime_length. Now throws TypeError.

Fixes: https://github.com/joyent/node/issues/8480
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
test: fix debug-signal-cluster after da update 2014-10-08T11:44:40+00:00 Fedor Indutny fedor@indutny.com 2014-10-08T10:35:07+00:00 d87480beb29b764ba37cd983b594ad25a406a4c7 The cluster children are hitting breakpoint at `cluster.onread` and hanging on a Semaphore wait now. This prevents them from disconnecting gracefully. Considering that the test is checking different thing, the cluster children needs to be force killed from the grand parent process. Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: https://github.com/joyent/node/pull/8476 
The cluster children are hitting breakpoint at `cluster.onread` and
hanging on a Semaphore wait now. This prevents them from disconnecting
gracefully. Considering that the test is checking different thing, the
cluster children needs to be force killed from the grand parent process.

Reviewed-By: Trevor Norris <trevnorris@gmail.com>
PR-URL: https://github.com/joyent/node/pull/8476
src, test: fixup after v8 update 2014-10-08T11:44:40+00:00 Fedor Indutny fedor@indutny.com 2014-10-08T10:34:51+00:00 685ac099e9d8085c363a51a15c718d160a6dcd5c Because of behavior change of some V8 APIs (they mostly became more strict), following modules needed to be fixed: * crypto: duplicate prototype methods are not allowed anymore * contextify: some TryCatch trickery, the binding was using it incorrectly * util: maximum call stack error is now crashing in a different place Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: https://github.com/joyent/node/pull/8476 
Because of behavior change of some V8 APIs (they mostly became more
    strict), following modules needed to be fixed:

* crypto: duplicate prototype methods are not allowed anymore
* contextify: some TryCatch trickery, the binding was using it
incorrectly
* util: maximum call stack error is now crashing in a different place

Reviewed-By: Trevor Norris <trevnorris@gmail.com>
PR-URL: https://github.com/joyent/node/pull/8476
deps: re-implement debugger-agent 2014-10-08T11:44:40+00:00 Fedor Indutny fedor@indutny.com 2014-10-04T14:44:39+00:00 7a0cfe9b116c6b5d56f7412d6ea71f5a8d8440e2 Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: https://github.com/joyent/node/pull/8476 
Reviewed-By: Trevor Norris <trevnorris@gmail.com>
PR-URL: https://github.com/joyent/node/pull/8476
streams: set default encoding for writable streams 2014-10-08T00:04:10+00:00 Johnny Ray http://johnnyray.me 2014-10-07T23:32:05+00:00 f04f3a0d012603fb7bbc3e1c05a5a6cd01ab4010 Add API Writable#setDefaultEncoding(). PR-URL: https://github.com/joyent/node/pull/8483 Fixes: https://github.com/joyent/node/issues/7159 Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Add API Writable#setDefaultEncoding().

PR-URL: https://github.com/joyent/node/pull/8483
Fixes: https://github.com/joyent/node/issues/7159
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
url: fixed encoding for slash switching emulation. 2014-10-07T00:25:25+00:00 Evan Rutledge Borden evan.borden@skedge.me 2014-09-26T15:59:39+00:00 640ad632e3bf04fe07fa2b9dc3ca940c2e8d0261 Fixes: https://github.com/joyent/node/issues/8458 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> 
Fixes: https://github.com/joyent/node/issues/8458
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
util: add es6 Symbol support for `util.inspect` 2014-10-03T17:12:00+00:00 gyson eilian.yunsong@gmail.com 2014-10-01T02:44:39+00:00 cb97bcd6f982b35a6fe4d41d884354f72905365d * `util.inspect` cannot accept es6 symbol primitive * It will throw exception if do `util.inspect(Symbol())` * This also affects repl, console.log, etc. Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> 
* `util.inspect` cannot accept es6 symbol primitive
* It will throw exception if do `util.inspect(Symbol())`
* This also affects repl, console.log, etc.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
buffer: add generic functions for (u)int ops 2014-10-03T08:31:20+00:00 Yazhong Liu yorkiefixer@gmail.com 2014-10-02T23:24:58+00:00 83d7d9e6d81fc35764a9000b6d7b17a0e7d8cc92 Add generic functions for (U)Int read/write operations on Buffers. These support up to and including 48 bit reads and writes. Include documentation and tests. Additional work done by Trevor Norris to include 40 and 48 bit write support. Because bitwise operations cannot be used on values greater than 32 bits, the operations have been replaced with mathematical calculations. Regardless, they are still faster than floating point operations. Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Add generic functions for (U)Int read/write operations on Buffers. These
support up to and including 48 bit reads and writes.

Include documentation and tests.

Additional work done by Trevor Norris to include 40 and 48 bit write
support. Because bitwise operations cannot be used on values greater
than 32 bits, the operations have been replaced with mathematical
calculations. Regardless, they are still faster than floating point
operations.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>