<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node.git/src, branch node-review</title>
<subtitle>github.com: joyent/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/'/>
<entry>
<title>build: fix issue with ETW support on win32</title>
<updated>2014-11-04T01:53:32+00:00</updated>
<author>
<name>Julien Gilli</name>
<email>julien.gilli@joyent.com</email>
</author>
<published>2014-11-04T01:53:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=fbcf03975932090bbcd05fa89e11866393613b0e'/>
<id>fbcf03975932090bbcd05fa89e11866393613b0e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>dtrace: fix ustack helper</title>
<updated>2014-10-17T20:31:51+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-17T20:31:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=28451aeabadc737f6bc8441b21c03b562a9e8e7f'/>
<id>28451aeabadc737f6bc8441b21c03b562a9e8e7f</id>
<content type='text'>
AsciiString is OneByteString now, use ONEBYTESTRINGTAG for ustack
helper.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
AsciiString is OneByteString now, use ONEBYTESTRINGTAG for ustack
helper.
</pre>
</div>
</content>
</entry>
<entry>
<title>v8_platform: provide default v8::Platform impl</title>
<updated>2014-10-16T17:47:55+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-10T22:17:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=552bcf3395477e954f06ac9d1de8ff0ac3e9824a'/>
<id>552bcf3395477e954f06ac9d1de8ff0ac3e9824a</id>
<content type='text'>
Provide default Platform implementation for v8's purposes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Provide default Platform implementation for v8's purposes.
</pre>
</div>
</content>
</entry>
<entry>
<title>src, test: fixup after v8 update</title>
<updated>2014-10-08T11:44:40+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-08T10:34:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=685ac099e9d8085c363a51a15c718d160a6dcd5c'/>
<id>685ac099e9d8085c363a51a15c718d160a6dcd5c</id>
<content type='text'>
Because of behavior change of some V8 APIs (they mostly became more
    strict), following modules needed to be fixed:

* crypto: duplicate prototype methods are not allowed anymore
* contextify: some TryCatch trickery, the binding was using it
incorrectly
* util: maximum call stack error is now crashing in a different place

Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Because of behavior change of some V8 APIs (they mostly became more
    strict), following modules needed to be fixed:

* crypto: duplicate prototype methods are not allowed anymore
* contextify: some TryCatch trickery, the binding was using it
incorrectly
* util: maximum call stack error is now crashing in a different place

Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</pre>
</div>
</content>
</entry>
<entry>
<title>deps: re-implement debugger-agent</title>
<updated>2014-10-08T11:44:40+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-04T14:44:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=7a0cfe9b116c6b5d56f7412d6ea71f5a8d8440e2'/>
<id>7a0cfe9b116c6b5d56f7412d6ea71f5a8d8440e2</id>
<content type='text'>
Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reviewed-By: Trevor Norris &lt;trevnorris@gmail.com&gt;
PR-URL: https://github.com/joyent/node/pull/8476
</pre>
</div>
</content>
</entry>
<entry>
<title>tls_wrap: ignore ZERO_RETURN after close_notify</title>
<updated>2014-10-08T11:32:55+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor@indutny.com</email>
</author>
<published>2014-10-06T12:23:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=a2a3fd48934f36d94575dd33d2a2cb732f937f77'/>
<id>a2a3fd48934f36d94575dd33d2a2cb732f937f77</id>
<content type='text'>
Do not call SSL_read() and ignore ZERO_RETURN if the connection was
shutdown and there could not be any reads.

Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
PR-URL: https://github.com/joyent/node/pull/8519
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Do not call SSL_read() and ignore ZERO_RETURN if the connection was
shutdown and there could not be any reads.

Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
PR-URL: https://github.com/joyent/node/pull/8519
</pre>
</div>
</content>
</entry>
<entry>
<title>src: update use of ExternalArrayType constants</title>
<updated>2014-10-08T08:34:46+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2014-10-08T08:34:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=bdc2ea4d52bd4a9871970ec2bfbf80292ca6e8e8'/>
<id>bdc2ea4d52bd4a9871970ec2bfbf80292ca6e8e8</id>
<content type='text'>
Continuation of 4809c7a to update the use of v8::ExternalArrayType.

Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Continuation of 4809c7a to update the use of v8::ExternalArrayType.

Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>smalloc: update use of ExternalArrayType constants</title>
<updated>2014-10-08T08:06:06+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2014-10-08T08:06:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=4809c7aa4f84385ba358d1947203fbeba8555b76'/>
<id>4809c7aa4f84385ba358d1947203fbeba8555b76</id>
<content type='text'>
The constants in enum v8::ExternalArrayType have been changed. The old
values are there for legacy reasons, but it's best to update anyway.

Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The constants in enum v8::ExternalArrayType have been changed. The old
values are there for legacy reasons, but it's best to update anyway.

Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>buffer: mv floating point read/write checks to JS</title>
<updated>2014-10-01T22:59:55+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2014-10-01T22:42:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=e9ca7b9d8de68e13d40698f34145e2a0428aa9d7'/>
<id>e9ca7b9d8de68e13d40698f34145e2a0428aa9d7</id>
<content type='text'>
Performance improvement by moving checks for floating point operations
to JS and doing the operation on a protected internal function that
assumes all arguments are correct. Still abort if the operation
overflows memory. This can only be caused if the Buffer's length
property isn't the same as the actual internal length.

Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Performance improvement by moving checks for floating point operations
to JS and doing the operation on a protected internal function that
assumes all arguments are correct. Still abort if the operation
overflows memory. This can only be caused if the Buffer's length
property isn't the same as the actual internal length.

Signed-off-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>node: avoid automatic microtask runs</title>
<updated>2014-10-01T21:42:05+00:00</updated>
<author>
<name>Vladimir Kurchatkin</name>
<email>vladimir.kurchatkin@gmail.com</email>
</author>
<published>2014-09-22T16:19:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=8dc6be1747d3a48af56f89e973ecb5665f89a2e1'/>
<id>8dc6be1747d3a48af56f89e973ecb5665f89a2e1</id>
<content type='text'>
Since we are taking control of the microtask queue it makes sense to
disable autorun and only run microtasks when necessary. Just setting
isolate-&gt;SetAutorunMicrotasks(false) would cause _tickCallback() not to
be called.

Automatically running the microtask queue will cause it to run:

* After callback invocation
* Inside _tickCallback()
* After _tickCallback() invocation

The third one is unnecessary as the microtask queue is guaranteed to be
empty at this point. The first only needs to be run manually when
_tickCallback() isn't going to be called by MakeCallback().

Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since we are taking control of the microtask queue it makes sense to
disable autorun and only run microtasks when necessary. Just setting
isolate-&gt;SetAutorunMicrotasks(false) would cause _tickCallback() not to
be called.

Automatically running the microtask queue will cause it to run:

* After callback invocation
* Inside _tickCallback()
* After _tickCallback() invocation

The third one is unnecessary as the microtask queue is guaranteed to be
empty at this point. The first only needs to be run manually when
_tickCallback() isn't going to be called by MakeCallback().

Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
