<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node.git/src/node_contextify.cc, branch move-debugger-tests</title>
<subtitle>github.com: joyent/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/'/>
<entry>
<title>base-object: add BaseObject</title>
<updated>2013-11-12T21:38:31+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2013-11-04T18:49:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=d120d92bfef0b5012e76c636335fee80e9c1e4a9'/>
<id>d120d92bfef0b5012e76c636335fee80e9c1e4a9</id>
<content type='text'>
BaseObject is a class that just handles the Persistent handle attached
to the class instance.

This also removed WeakObject. Reordering the inheritance chain helps
prevent unneeded calls on instances that don't call MakeCallback.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BaseObject is a class that just handles the Persistent handle attached
to the class instance.

This also removed WeakObject. Reordering the inheritance chain helps
prevent unneeded calls on instances that don't call MakeCallback.
</pre>
</div>
</content>
</entry>
<entry>
<title>src: fix Environment::GetCurrent() usage</title>
<updated>2013-11-11T09:40:28+00:00</updated>
<author>
<name>Ben Noordhuis</name>
<email>info@bnoordhuis.nl</email>
</author>
<published>2013-11-11T21:02:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=09724b311ee44e6c7998c7a5cb39e739609eba66'/>
<id>09724b311ee44e6c7998c7a5cb39e739609eba66</id>
<content type='text'>
Create a HandleScope before calling the Environment::GetCurrent() that
takes a v8::Isolate* as an argument because it creates a handle with
the call to v8::Isolate::CurrentContext().
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Create a HandleScope before calling the Environment::GetCurrent() that
takes a v8::Isolate* as an argument because it creates a handle with
the call to v8::Isolate::CurrentContext().
</pre>
</div>
</content>
</entry>
<entry>
<title>async-wrap: integrate with WeakObject</title>
<updated>2013-10-31T21:17:51+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2013-09-27T17:30:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=8b8e3b67980d5be9feb03839c2821bd8be3680a3'/>
<id>8b8e3b67980d5be9feb03839c2821bd8be3680a3</id>
<content type='text'>
Making WeakObject inherit from AsyncWrap allows us to peak into almost
all the MakeCallback calls in Node internals.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Making WeakObject inherit from AsyncWrap allows us to peak into almost
all the MakeCallback calls in Node internals.
</pre>
</div>
</content>
</entry>
<entry>
<title>src: shorten Object{Wrap,Unwrap}</title>
<updated>2013-10-29T22:09:44+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2013-10-29T20:23:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=613d76ef6a00ec091367de1e63bc51e3ab672cbd'/>
<id>613d76ef6a00ec091367de1e63bc51e3ab672cbd</id>
<content type='text'>
Going back to the original names of Wrap/Unwrap now that most all the
class members that duplicate the name and functionality have been
removed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Going back to the original names of Wrap/Unwrap now that most all the
class members that duplicate the name and functionality have been
removed.
</pre>
</div>
</content>
</entry>
<entry>
<title>src: don't use WeakObject::Unwrap</title>
<updated>2013-10-29T22:09:44+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2013-10-29T19:49:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=60a3e695cb6ff09f81de4195368535fdb11e2da9'/>
<id>60a3e695cb6ff09f81de4195368535fdb11e2da9</id>
<content type='text'>
Switch out to use UnwrapObject from util.h.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Switch out to use UnwrapObject from util.h.
</pre>
</div>
</content>
</entry>
<entry>
<title>src: use function to get internal pointer</title>
<updated>2013-10-29T22:09:44+00:00</updated>
<author>
<name>Trevor Norris</name>
<email>trev.norris@gmail.com</email>
</author>
<published>2013-10-29T19:27:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=93f75a86bf6c87aa897312740aab61282b0eff1d'/>
<id>93f75a86bf6c87aa897312740aab61282b0eff1d</id>
<content type='text'>
Remove the NODE_{WRAP,UNWRAP} macros and instead use template functions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove the NODE_{WRAP,UNWRAP} macros and instead use template functions.
</pre>
</div>
</content>
</entry>
<entry>
<title>vm: Copy missing properties from context</title>
<updated>2013-10-28T15:43:43+00:00</updated>
<author>
<name>isaacs</name>
<email>i@izs.me</email>
</author>
<published>2013-10-26T01:56:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=3c5ea410ca56da3d4785e2563cb2724364669fd2'/>
<id>3c5ea410ca56da3d4785e2563cb2724364669fd2</id>
<content type='text'>
This addresses a current shortcoming of the V8 SetNamedPropertyHandler
function.

It does not provide a way to intercept Object.defineProperty(..) calls.
As a result, these properties are not copied onto the contextified
sandbox when a new global property is added via either a function
declaration or a Object.defineProperty(global, ...) call.

Note that any function declarations or Object.defineProperty() globals
that are created asynchronously (in a setTimeout, callback, etc.) will
happen AFTER the call to copy properties, and thus not be caught.

The way to properly fix this is to add some sort of a
Object::SetNamedDefinePropertyHandler() function that takes a callback,
which receives the property name and property descriptor as arguments.

Luckily, such situations are rare, and asynchronously-added globals
weren't supported by Node's VM module until 0.12 anyway.  But, this
should be fixed properly in V8, and this copy function should be removed
once there is a better way.

Fix #6416
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This addresses a current shortcoming of the V8 SetNamedPropertyHandler
function.

It does not provide a way to intercept Object.defineProperty(..) calls.
As a result, these properties are not copied onto the contextified
sandbox when a new global property is added via either a function
declaration or a Object.defineProperty(global, ...) call.

Note that any function declarations or Object.defineProperty() globals
that are created asynchronously (in a setTimeout, callback, etc.) will
happen AFTER the call to copy properties, and thus not be caught.

The way to properly fix this is to add some sort of a
Object::SetNamedDefinePropertyHandler() function that takes a callback,
which receives the property name and property descriptor as arguments.

Luckily, such situations are rare, and asynchronously-added globals
weren't supported by Node's VM module until 0.12 anyway.  But, this
should be fixed properly in V8, and this copy function should be removed
once there is a better way.

Fix #6416
</pre>
</div>
</content>
</entry>
<entry>
<title>cpplint: disallow comma-first in C++</title>
<updated>2013-10-16T20:34:18+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor.indutny@gmail.com</email>
</author>
<published>2013-10-16T16:34:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=7063c59b97fa4f365f9e5ec1f563235ede4104db'/>
<id>7063c59b97fa4f365f9e5ec1f563235ede4104db</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>src: remove ObjectWrap dependency from core</title>
<updated>2013-09-25T17:44:53+00:00</updated>
<author>
<name>Ben Noordhuis</name>
<email>info@bnoordhuis.nl</email>
</author>
<published>2013-09-25T10:57:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=c79d5163e530892c62b08d8b814b588220c26ec8'/>
<id>c79d5163e530892c62b08d8b814b588220c26ec8</id>
<content type='text'>
Drop the ObjectWrap dependency in favor of an internal WeakObject class.

Let's us stop worrying about API and ABI compatibility when making
changes to the way node.js deals with weakly persistent handles
internally.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Drop the ObjectWrap dependency in favor of an internal WeakObject class.

Let's us stop worrying about API and ABI compatibility when making
changes to the way node.js deals with weakly persistent handles
internally.
</pre>
</div>
</content>
</entry>
<entry>
<title>contextify: fix ContextifyContext leak</title>
<updated>2013-09-14T20:56:11+00:00</updated>
<author>
<name>Fedor Indutny</name>
<email>fedor.indutny@gmail.com</email>
</author>
<published>2013-09-14T14:29:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=59a075e108c7ffcee87252255e60530cd15a8adb'/>
<id>59a075e108c7ffcee87252255e60530cd15a8adb</id>
<content type='text'>
Apparently, context-&gt;Global() won't be destroyed if the context itself
isn't marked as weak and independent.

Also, the weakness flag should be cleared once the weak callback is
executed, otherwise we'll get crashes in Debug builds.

fix #6115 and #6201
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Apparently, context-&gt;Global() won't be destroyed if the context itself
isn't marked as weak and independent.

Also, the weakness flag should be cleared once the weak callback is
executed, otherwise we'll get crashes in Debug builds.

fix #6115 and #6201
</pre>
</div>
</content>
</entry>
</feed>
