delta/node.git/lib, branch node-review github.com: joyent/node.git streams: make setDefaultEncoding() throw 2014-10-09T23:48:59+00:00 Brian White mscdex@mscdex.net 2014-10-09T20:07:50+00:00 874dd590cf385baa534556eadee0fa5c2f985519 PR-URL: https://github.com/joyent/node/pull/8529 Fixes: f04f3a0 "streams: set default encoding for writable streams" [trev.norris@gmail.com: update tests to check if throws] Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
PR-URL: https://github.com/joyent/node/pull/8529
Fixes: f04f3a0 "streams: set default encoding for writable streams"
[trev.norris@gmail.com: update tests to check if throws]
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
crypto: createDiffieHellman throw for bad args 2014-10-08T22:38:46+00:00 Trevor Norris trev.norris@gmail.com 2014-10-08T22:38:46+00:00 1a4a189578944f62b3dfb6f4fc8dabe20a7535ee Previously crypto.createDiffieHellman() would fail silently when a bad argument was passed for prime/prime_length. Now throws TypeError. Fixes: https://github.com/joyent/node/issues/8480 Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
Previously crypto.createDiffieHellman() would fail silently when a bad
argument was passed for prime/prime_length. Now throws TypeError.

Fixes: https://github.com/joyent/node/issues/8480
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
cluster: do not signal children in debug mode 2014-10-08T11:44:40+00:00 Fedor Indutny fedor@indutny.com 2014-10-04T14:44:46+00:00 42ecd48c7f68f204a4986477089b496bf994ee6e Do not send signal to children if they are already in debug mode. Node.js on Windows does not register signal handler, and thus calling `process._debugProcess()` will throw an error. Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: https://github.com/joyent/node/pull/8476 
Do not send signal to children if they are already in debug mode.
Node.js on Windows does not register signal handler, and thus calling
`process._debugProcess()` will throw an error.

Reviewed-By: Trevor Norris <trevnorris@gmail.com>
PR-URL: https://github.com/joyent/node/pull/8476
deps: re-implement debugger-agent 2014-10-08T11:44:40+00:00 Fedor Indutny fedor@indutny.com 2014-10-04T14:44:39+00:00 7a0cfe9b116c6b5d56f7412d6ea71f5a8d8440e2 Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: https://github.com/joyent/node/pull/8476 
Reviewed-By: Trevor Norris <trevnorris@gmail.com>
PR-URL: https://github.com/joyent/node/pull/8476
buffer, doc: misc. fix and cleanup 2014-10-08T09:24:32+00:00 Trevor Norris trev.norris@gmail.com 2014-10-08T09:08:54+00:00 6462519d3cb7c34671dddb3cedd8441699574f35 * Add official documentation that a Buffer instance is a viable argument when instantiating a new Buffer. * Properly set the poolOffset when a buffer needs to be truncated. * Add comments clarifying specific peculiar coding choices. * Remove a level of unnecessary indentation. Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
* Add official documentation that a Buffer instance is a viable
  argument when instantiating a new Buffer.
* Properly set the poolOffset when a buffer needs to be truncated.
* Add comments clarifying specific peculiar coding choices.
* Remove a level of unnecessary indentation.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
src: fix jslint warning 2014-10-08T08:13:43+00:00 Trevor Norris trev.norris@gmail.com 2014-10-08T08:13:43+00:00 7b4a540422f2155f0e57d963be69960c1325474d Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
smalloc: update use of ExternalArrayType constants 2014-10-08T08:06:06+00:00 Trevor Norris trev.norris@gmail.com 2014-10-08T08:06:06+00:00 4809c7aa4f84385ba358d1947203fbeba8555b76 The constants in enum v8::ExternalArrayType have been changed. The old values are there for legacy reasons, but it's best to update anyway. Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
The constants in enum v8::ExternalArrayType have been changed. The old
values are there for legacy reasons, but it's best to update anyway.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
streams: set default encoding for writable streams 2014-10-08T00:04:10+00:00 Johnny Ray http://johnnyray.me 2014-10-07T23:32:05+00:00 f04f3a0d012603fb7bbc3e1c05a5a6cd01ab4010 Add API Writable#setDefaultEncoding(). PR-URL: https://github.com/joyent/node/pull/8483 Fixes: https://github.com/joyent/node/issues/7159 Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Add API Writable#setDefaultEncoding().

PR-URL: https://github.com/joyent/node/pull/8483
Fixes: https://github.com/joyent/node/issues/7159
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
url: fixed encoding for slash switching emulation. 2014-10-07T00:25:25+00:00 Evan Rutledge Borden evan.borden@skedge.me 2014-09-26T15:59:39+00:00 640ad632e3bf04fe07fa2b9dc3ca940c2e8d0261 Fixes: https://github.com/joyent/node/issues/8458 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> 
Fixes: https://github.com/joyent/node/issues/8458
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
util: add es6 Symbol support for `util.inspect` 2014-10-03T17:12:00+00:00 gyson eilian.yunsong@gmail.com 2014-10-01T02:44:39+00:00 cb97bcd6f982b35a6fe4d41d884354f72905365d * `util.inspect` cannot accept es6 symbol primitive * It will throw exception if do `util.inspect(Symbol())` * This also affects repl, console.log, etc. Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> 
* `util.inspect` cannot accept es6 symbol primitive
* It will throw exception if do `util.inspect(Symbol())`
* This also affects repl, console.log, etc.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>