<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node.git/lib/_http_agent.js, branch fix/orangemocha-readable-stuff</title>
<subtitle>github.com: joyent/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/'/>
<entry>
<title>http: remove the circular dependency</title>
<updated>2014-02-26T21:19:36+00:00</updated>
<author>
<name>Nathan Rajlich</name>
<email>nathan@tootallnate.net</email>
</author>
<published>2014-02-25T22:19:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=f3189ace6b5e31a874df421ac2f74da0e77cb14d'/>
<id>f3189ace6b5e31a874df421ac2f74da0e77cb14d</id>
<content type='text'>
Between `ClientRequest` and `Agent`. The circular require was doing
weird things at load time, like making the `globalAgent` property
be `undefined` from within the context of the "_http_client"
module.

Removing the circular dependency completely fixes this.

This commit effectively removes the undocumented `Agent#request()`
and `Agent#get()` functions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Between `ClientRequest` and `Agent`. The circular require was doing
weird things at load time, like making the `globalAgent` property
be `undefined` from within the context of the "_http_client"
module.

Removing the circular dependency completely fixes this.

This commit effectively removes the undocumented `Agent#request()`
and `Agent#get()` functions.
</pre>
</div>
</content>
</entry>
<entry>
<title>http: force socket encoding to be null</title>
<updated>2013-11-07T16:24:50+00:00</updated>
<author>
<name>isaacs</name>
<email>i@izs.me</email>
</author>
<published>2013-11-03T22:32:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=ea8feced871849715608cc47618d8ee1cf82742b'/>
<id>ea8feced871849715608cc47618d8ee1cf82742b</id>
<content type='text'>
Otherwise the string triggers an assertion error in node_http_parser.c,
line 370:

    assert(Buffer::HasInstance(args[0]) == true);

because the first argument is not a Buffer object.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Otherwise the string triggers an assertion error in node_http_parser.c,
line 370:

    assert(Buffer::HasInstance(args[0]) == true);

because the first argument is not a Buffer object.
</pre>
</div>
</content>
</entry>
<entry>
<title>http: cleanup freeSockets when socket destroyed</title>
<updated>2013-11-07T07:42:41+00:00</updated>
<author>
<name>fengmk2</name>
<email>fengmk2@gmail.com</email>
</author>
<published>2013-11-06T11:58:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=1ce5db4d95ef8d522592db33a131780754935fc3'/>
<id>1ce5db4d95ef8d522592db33a131780754935fc3</id>
<content type='text'>
If the socket was destroyed, we need to remove it from the agent's
`freeSockets` list, otherwise dead socket could be reused by new
request.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the socket was destroyed, we need to remove it from the agent's
`freeSockets` list, otherwise dead socket could be reused by new
request.
</pre>
</div>
</content>
</entry>
<entry>
<title>http: don't pass the request options to Agent</title>
<updated>2013-09-14T19:29:48+00:00</updated>
<author>
<name>Nathan Rajlich</name>
<email>nathan@tootallnate.net</email>
</author>
<published>2013-09-13T23:54:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=f31037ddfefdc8fab94980cd16a525827ba19abf'/>
<id>f31037ddfefdc8fab94980cd16a525827ba19abf</id>
<content type='text'>
The `options` that were being passed in before here are specific to a
single request, which kinda defeats the purpose of using an Agent in the
first place.

On a worse note, these `options` have not yet been "processed" by the
`http.ClientRequest` class, so if `port: null` is set (like it is as the
result of a `url.parse()` call), then they take preference over the
processed values since the agent's "options" get mixed in last in the
`createSocket()` function.

Fixes #6197.
Fixes #6199.
Closes #6231.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `options` that were being passed in before here are specific to a
single request, which kinda defeats the purpose of using an Agent in the
first place.

On a worse note, these `options` have not yet been "processed" by the
`http.ClientRequest` class, so if `port: null` is set (like it is as the
result of a `url.parse()` call), then they take preference over the
processed values since the agent's "options" get mixed in last in the
`createSocket()` function.

Fixes #6197.
Fixes #6199.
Closes #6231.
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: remove unused variables and functions</title>
<updated>2013-08-16T00:19:17+00:00</updated>
<author>
<name>Brian White</name>
<email>mscdex@mscdex.net</email>
</author>
<published>2013-08-15T21:55:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=6d842897c5966cee1924b5073e273568923c8693'/>
<id>6d842897c5966cee1924b5073e273568923c8693</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>http: add agent.maxFreeSockets option</title>
<updated>2013-08-15T20:54:28+00:00</updated>
<author>
<name>isaacs</name>
<email>i@izs.me</email>
</author>
<published>2013-08-05T03:54:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=65f6f06a61c36630ee405a697b1d876208212874'/>
<id>65f6f06a61c36630ee405a697b1d876208212874</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>http: Support legacy agent.addRequest API</title>
<updated>2013-08-07T17:29:15+00:00</updated>
<author>
<name>isaacs</name>
<email>i@izs.me</email>
</author>
<published>2013-08-07T17:23:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=12cd13312b1bd1ea1642c0058bbc14be72c347f0'/>
<id>12cd13312b1bd1ea1642c0058bbc14be72c347f0</id>
<content type='text'>
There are some agent subclasses using this today.

Despite the addRequest function being undocumented internal API, it's
easy enough to just support the old signature for backwards
compatibility.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are some agent subclasses using this today.

Despite the addRequest function being undocumented internal API, it's
easy enough to just support the old signature for backwards
compatibility.
</pre>
</div>
</content>
</entry>
<entry>
<title>http: Fix overlooked agent.globalAgent export</title>
<updated>2013-08-05T19:33:19+00:00</updated>
<author>
<name>isaacs</name>
<email>i@izs.me</email>
</author>
<published>2013-08-05T19:33:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=32fdae2ca3bd4df057ae01b7cd78961968fa0fd0'/>
<id>32fdae2ca3bd4df057ae01b7cd78961968fa0fd0</id>
<content type='text'>
Noticed by @bnoordhuis in https://github.com/joyent/node/pull/5991#discussion_r5575946
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Noticed by @bnoordhuis in https://github.com/joyent/node/pull/5991#discussion_r5575946
</pre>
</div>
</content>
</entry>
<entry>
<title>src: Replace macros with util functions</title>
<updated>2013-08-01T22:08:01+00:00</updated>
<author>
<name>isaacs</name>
<email>i@izs.me</email>
</author>
<published>2013-07-26T21:38:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=22c68fdc1dae40f0ed9c71a02f66e5b2c6353691'/>
<id>22c68fdc1dae40f0ed9c71a02f66e5b2c6353691</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: macro-ify type checks</title>
<updated>2013-07-24T19:49:35+00:00</updated>
<author>
<name>Ben Noordhuis</name>
<email>info@bnoordhuis.nl</email>
</author>
<published>2013-07-24T16:03:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node.git/commit/?id=0330bdf5195eb77f04c26a09a8bd2088a261fe53'/>
<id>0330bdf5195eb77f04c26a09a8bd2088a261fe53</id>
<content type='text'>
Increases the grep factor. Makes it easier to harmonize type checks
across the code base.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Increases the grep factor. Makes it easier to harmonize type checks
across the code base.
</pre>
</div>
</content>
</entry>
</feed>
