delta/node.git/doc, branch node-review github.com: joyent/node.git doc: correct createSecureContext 2014-10-09T18:46:58+00:00 Wang Xinyong wang.xy.chn@gmail.com 2014-10-09T17:15:05+00:00 db7df57e0342a5a6922bd2700ffc78c5a99841c8 Remove incorrect stablity indication of tls.createSecureContext, and format stablity indication of crypto.createCredentials. Fixes: e50749 "doc: document `tls.createSecureContext`" Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Remove incorrect stablity indication of tls.createSecureContext, and
format stablity indication of crypto.createCredentials.

Fixes: e50749 "doc: document `tls.createSecureContext`"
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
doc: fix wording and punctuation in modules 2014-10-08T23:48:31+00:00 Stiliyan Lazarov stiliyanlazarov@gmail.com 2014-10-04T14:50:50+00:00 47f119cabfc2eb7e524bc6584fd01328f9ce95d1 [trev.norris@gmail.com: break lines at 80 characters] Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
[trev.norris@gmail.com: break lines at 80 characters]
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
buffer, doc: misc. fix and cleanup 2014-10-08T09:24:32+00:00 Trevor Norris trev.norris@gmail.com 2014-10-08T09:08:54+00:00 6462519d3cb7c34671dddb3cedd8441699574f35 * Add official documentation that a Buffer instance is a viable argument when instantiating a new Buffer. * Properly set the poolOffset when a buffer needs to be truncated. * Add comments clarifying specific peculiar coding choices. * Remove a level of unnecessary indentation. Signed-off-by: Trevor Norris <trev.norris@gmail.com> 
* Add official documentation that a Buffer instance is a viable
  argument when instantiating a new Buffer.
* Properly set the poolOffset when a buffer needs to be truncated.
* Add comments clarifying specific peculiar coding choices.
* Remove a level of unnecessary indentation.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
doc: add missing semicolons 2014-10-08T06:30:42+00:00 Steve Mao maochenyan@msn.com 2014-10-03T05:53:15+00:00 6e4bd494a50c3dfd432a5a6dd4a13556443dfa79 PR-URL: https://github.com/joyent/node/pull/8498 Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
PR-URL: https://github.com/joyent/node/pull/8498
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
streams: set default encoding for writable streams 2014-10-08T00:04:10+00:00 Johnny Ray http://johnnyray.me 2014-10-07T23:32:05+00:00 f04f3a0d012603fb7bbc3e1c05a5a6cd01ab4010 Add API Writable#setDefaultEncoding(). PR-URL: https://github.com/joyent/node/pull/8483 Fixes: https://github.com/joyent/node/issues/7159 Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Add API Writable#setDefaultEncoding().

PR-URL: https://github.com/joyent/node/pull/8483
Fixes: https://github.com/joyent/node/issues/7159
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
doc: improve readLine.pause() 2014-10-07T00:24:29+00:00 Victor Widell victor@topmost.se 2014-03-30T10:34:45+00:00 8392e8cdfb71e8cc03e110f7b30ed104b3b136bd The docs for readLine.pause are misleading. I seriously spent hours on this. If it isn't a bug, at least it should be well documented. Someone else stumbled on this too: http://stackoverflow.com/questions/21341050/pausing-readline-in-node-js Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> 
The docs for readLine.pause are misleading. I seriously spent hours on this. If
it isn't a bug, at least it should be well documented.

Someone else stumbled on this too:
http://stackoverflow.com/questions/21341050/pausing-readline-in-node-js

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
doc: Update net.markdown 2014-10-07T00:24:21+00:00 Steve Sharp stevenson.sharp@gmail.com 2014-09-28T23:03:25+00:00 87ce067636a6ea52cd978c68f9e837d5d115b4f0 Associates link to dns.lookup() with proper URL. Fixes: https://github.com/joyent/node/issues/8018 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> 
Associates link to dns.lookup() with proper URL.

Fixes: https://github.com/joyent/node/issues/8018
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
buffer: add generic functions for (u)int ops 2014-10-03T08:31:20+00:00 Yazhong Liu yorkiefixer@gmail.com 2014-10-02T23:24:58+00:00 83d7d9e6d81fc35764a9000b6d7b17a0e7d8cc92 Add generic functions for (U)Int read/write operations on Buffers. These support up to and including 48 bit reads and writes. Include documentation and tests. Additional work done by Trevor Norris to include 40 and 48 bit write support. Because bitwise operations cannot be used on values greater than 32 bits, the operations have been replaced with mathematical calculations. Regardless, they are still faster than floating point operations. Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Add generic functions for (U)Int read/write operations on Buffers. These
support up to and including 48 bit reads and writes.

Include documentation and tests.

Additional work done by Trevor Norris to include 40 and 48 bit write
support. Because bitwise operations cannot be used on values greater
than 32 bits, the operations have been replaced with mathematical
calculations. Regardless, they are still faster than floating point
operations.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
readline: should not require an output stream. 2014-10-01T22:00:02+00:00 Julien Gilli julien.gilli@joyent.com 2014-09-22T20:21:11+00:00 862cc28183b03f0e1a67b052b5c8250a3e2e8995 Passing null as the output stream to readline.Interface()'s constructor is now supported. Any output written by readline is just discarded. It makes it easier to use readline just as a line parser. Fixes: https://github.com/joyent/node/issues/4408 Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Passing null as the output stream to readline.Interface()'s constructor
is now supported. Any output written by readline is just discarded. It
makes it easier to use readline just as a line parser.

Fixes: https://github.com/joyent/node/issues/4408
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
url: make query() consistent 2014-10-01T19:23:01+00:00 Gabriel Wicke wicke@wikidev.net 2014-09-25T16:59:18+00:00 b705b73e46193c7691be40b732330a49affacedb Match the behavior of the slow path by setting url.query to an empty object when the url contains no query, but query parsing is requested. Also add a test for this case, and update the documents to clearly reflect this behavior. Fixes: https://github.com/joyent/node/issues/8332 Reviewed-by: Trevor Norris <trev.norris@gmail.com> 
Match the behavior of the slow path by setting url.query to an empty
object when the url contains no query, but query parsing is requested.

Also add a test for this case, and update the documents to clearly
reflect this behavior.

Fixes: https://github.com/joyent/node/issues/8332
Reviewed-by: Trevor Norris <trev.norris@gmail.com>