From 2883c855e0105b51e5c8020d21458af109ffe3d4 Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Thu, 5 Mar 2020 10:49:19 -0800 Subject: deps: update V8 to 8.1.307.20 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaƫl Zasso Reviewed-By: Jiawen Geng Reviewed-By: Ruben Bridgewater --- deps/v8/src/execution/frames.cc | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) (limited to 'deps/v8/src/execution/frames.cc') diff --git a/deps/v8/src/execution/frames.cc b/deps/v8/src/execution/frames.cc index 04768a365c..8337a63e17 100644 --- a/deps/v8/src/execution/frames.cc +++ b/deps/v8/src/execution/frames.cc @@ -455,7 +455,10 @@ void SafeStackFrameIterator::Advance() { last_callback_scope = external_callback_scope_; external_callback_scope_ = external_callback_scope_->previous(); } - if (frame_->is_java_script() || frame_->is_wasm()) break; + if (frame_->is_java_script() || frame_->is_wasm() || + frame_->is_wasm_to_js()) { + break; + } if (frame_->is_exit() || frame_->is_builtin_exit()) { // Some of the EXIT frames may have ExternalCallbackScope allocated on // top of them. In that case the scope corresponds to the first EXIT @@ -489,7 +492,8 @@ Code StackFrame::LookupCode() const { void StackFrame::IteratePc(RootVisitor* v, Address* pc_address, Address* constant_pool_address, Code holder) { Address pc = *pc_address; - DCHECK(holder.GetHeap()->GcSafeCodeContains(holder, pc)); + DCHECK(ReadOnlyHeap::Contains(holder) || + holder.GetHeap()->GcSafeCodeContains(holder, pc)); unsigned pc_offset = static_cast(pc - holder.InstructionStart()); Object code = holder; v->VisitRootPointer(Root::kTop, nullptr, FullObjectSlot(&code)); @@ -1316,7 +1320,7 @@ Object JavaScriptBuiltinContinuationFrame::context() const { void JavaScriptBuiltinContinuationWithCatchFrame::SetException( Object exception) { Address exception_argument_slot = - fp() + JavaScriptFrameConstants::kLastParameterOffset + + fp() + BuiltinContinuationFrameConstants::kFixedFrameSizeAboveFp + kSystemPointerSize; // Skip over return value slot. // Only allow setting exception if previous value was the hole. @@ -1413,11 +1417,9 @@ WASM_SUMMARY_DISPATCH(int, byte_offset) #undef WASM_SUMMARY_DISPATCH int FrameSummary::WasmFrameSummary::SourcePosition() const { - Handle module_object(wasm_instance()->module_object(), - isolate()); - return WasmModuleObject::GetSourcePosition(module_object, function_index(), - byte_offset(), - at_to_number_conversion()); + const wasm::WasmModule* module = wasm_instance()->module_object().module(); + return GetSourcePosition(module, function_index(), byte_offset(), + at_to_number_conversion()); } Handle