summaryrefslogtreecommitdiff
path: root/benchmark
Commit message (Collapse)AuthorAgeFilesLines
* async_hooks: add async local storage propagation benchmarksChengzhong Wu2023-02-034-0/+186
| | | | | | | | | | | | | Add micro-benchmarks to verify the performance degradation related to the number of active `AsyncLocalStorage`s. With these benchmarks, trying to improve the async context propagation to be an O(1) operation, which is an operation more frequent compared to `asyncLocalStorage.run` and `asyncLocalStorage.getStore`. PR-URL: https://github.com/nodejs/node/pull/46414 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* benchmark: add trailing commas in `benchmark/module`Antoine du Hamel2023-02-035-11/+10
| | | | | | PR-URL: https://github.com/nodejs/node/pull/46461 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add trailing commas in `benchmark/net`Antoine du Hamel2023-02-038-17/+16
| | | | | PR-URL: https://github.com/nodejs/node/pull/46439 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add trailing commas in `benchmark/util`Antoine du Hamel2023-02-0310-18/+17
| | | | | PR-URL: https://github.com/nodejs/node/pull/46438 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add trailing commas in `benchmark/async_hooks`Antoine du Hamel2023-02-016-22/+21
| | | | | | PR-URL: https://github.com/nodejs/node/pull/46424 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* benchmark: add trailing commas in `benchmark/fs`Antoine du Hamel2023-02-0115-16/+15
| | | | | | PR-URL: https://github.com/nodejs/node/pull/46426 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
* benchmark: add trailing commasAntoine du Hamel2023-01-2984-116/+134
| | | | | | PR-URL: https://github.com/nodejs/node/pull/46370 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: require more trailing commasAntoine du Hamel2023-01-251-2/+2
| | | | | | | | | | All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that. PR-URL: https://github.com/nodejs/node/pull/46346 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* url: refactor to use more primordialsAntoine du Hamel2023-01-221-0/+30
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45966 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* benchmark: remove buffer benchmarks redundancyBrian White2023-01-223-2/+18
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45735 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* benchmark: introduce benchmark combination filteringBrian White2023-01-221-1/+22
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45735 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* benchmark,tools: use os.availableParallelism()Deokjin Kim2023-01-111-1/+1
| | | | | | | | | Refs: https://github.com/nodejs/node/pull/45895 PR-URL: https://github.com/nodejs/node/pull/46003 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* tools: add `prefer-proto` ruleJordan Harband2023-01-101-2/+2
| | | | | | | | | | | | | | | | fixup: add support for `Object.create(null)` fixup: extend to any 1-argument Object.create call fixup: add tests PR-URL: https://github.com/nodejs/node/pull/46083 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* src: speed up process.getActiveResourcesInfo()Darshan Sen2023-01-031-0/+45
| | | | | | | | | | | | This change reduces the number of calls that were crossing the JS-C++ boundary to 1 and also removes the need for calling Array::New() multiple times internally and ArrayPrototypeConcat-ing the results later on, thus improving performance. Refs: https://github.com/nodejs/node/pull/44445#pullrequestreview-1220052837 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/46014 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* util: add fast path for text-decoder fatal flagYagiz Nizipli2022-12-221-3/+8
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
* benchmark: include webstreams benchmarkRafael Gonzaga2022-12-213-0/+116
| | | | | | Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
* tools: enforce use of trailing commas in `tools/`Antoine du Hamel2022-12-181-0/+7
| | | | | PR-URL: https://github.com/nodejs/node/pull/45889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* crypto: use globalThis.crypto over require('crypto').webcryptoFilip Skokan2022-12-161-6/+3
| | | | | PR-URL: https://github.com/nodejs/node/pull/45817 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add variety of inputs to text-encoderYagiz Nizipli2022-12-101-5/+18
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45787 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
* benchmark: make benchmarks runnable in older versions of Node.jsJoyee Cheung2022-12-083-64/+43
| | | | | | | | | | | | | | Also remove the require-cachable.js benchmarks because now all builtin modules are cacheable, it would be comparing oranges to apples when we try to compare the performance of loading all cacheable modules in different Node.js binaries since the set of modules are just different. Comparison of startup performance that involves loading of the long-standing, stable builtins is already covered by the require-builtins benchmark. PR-URL: https://github.com/nodejs/node/pull/45746 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* benchmark: add v8 serialize benchmarkYagiz Nizipli2022-11-211-0/+17
| | | | | PR-URL: https://github.com/nodejs/node/pull/45476 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* benchmark: add text-encoder benchmarkYagiz Nizipli2022-11-181-0/+32
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45450 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* buffer: introduce FileKhafra2022-11-101-0/+34
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/45139 Fixes: https://github.com/nodejs/node/issues/39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* benchmark: add parameters to text-decoder benchmarkYagiz Nizipli2022-11-091-3/+19
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* benchmark: fix text-decoder benchmarkYagiz Nizipli2022-11-091-1/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* util: improve textdecoder decode performanceYagiz Nizipli2022-11-061-0/+19
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45294 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* lib: performance improvement on readline async iteratorThiago Oliveira Santos2022-10-241-0/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using a direct approach to create the readline async iterator allowed an iteration over 20 to 58% faster. **BREAKING CHANGE**: With that change, the async iteterator obtained from the readline interface doesn't have the property "stream" any longer. This happened because it's no longer created through a Readable, instead, the async iterator is created directly from the events of the readline interface instance, so, if anyone is using that property, this change will break their code. Also, the Readable added a backpressure control that is fairly compensated by the use of FixedQueue + monitoring its size. This control wasn't really precise with readline before, though, because it only pauses the reading of the original stream, but the lines generated from the last message received from it was still emitted. For example: if the readable was paused at 1000 messages but the last one received generated 10k lines, but no further messages were emitted again until the queue was lower than the readable highWaterMark. A similar behavior still happens with the new implementation, but the highWaterMark used is fixed: 1024, and the original stream is resumed again only after the queue is cleared. Before making that change, I created a package implementing the same concept used here to validate it. You can find it [here](https://github.com/Farenheith/faster-readline-iterator) if this helps anyhow. PR-URL: https://github.com/nodejs/node/pull/41276 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add blob benchmarkYagiz Nizipli2022-10-171-0/+30
| | | | | | PR-URL: https://github.com/nodejs/node/pull/44990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* events: add unique events benchmarkYagiz Nizipli2022-10-141-0/+35
| | | | | | | | Co-authored-by: Brian White <mscdex@mscdex.net> PR-URL: https://github.com/nodejs/node/pull/44657 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* fs: improve promise based readFile performance for big filesRuben Bridgewater2022-10-061-1/+8
| | | | | | | | | | This significantly reduces the peak memory for the promise based readFile operation by reusing a single memory chunk after each read and strinigifying that chunk immediately. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/44295 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add vm context global proxy benchmarkJoyee Cheung2022-10-041-0/+21
| | | | | | PR-URL: https://github.com/nodejs/node/pull/44796 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: upgrade all 1024 bit RSA keys to 2048 bitsMomtchil Momtchev2022-09-272-2/+2
| | | | | | | | | Ubuntu 22.04 Jammy rejects 1024 bit RSA Keys PR-URL: https://github.com/nodejs/node/pull/44498 Refs: https://github.com/nodejs/node/issues/44497 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* benchmark: fix startup benchmarkEvan Lucas2022-09-211-2/+2
| | | | | | | | | | | | This allows the misc/startup benchmark to run again after the renaming of the C++ `native_module` to `builtins` PR-URL: https://github.com/nodejs/node/pull/44727 Refs: https://github.com/nodejs/node/pull/44135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* benchmark: add stream destroy benchmarkSindreXie2022-09-131-0/+56
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/44533 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
* lib: fix reference leakfalsandtru2022-09-072-0/+67
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/44499 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* fs: add encoding parameter to benchmarksYagiz Nizipli2022-08-213-8/+11
| | | | | PR-URL: https://github.com/nodejs/node/pull/44278 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* src,lib: print source map error source on demandlegendecas2022-07-283-0/+66
| | | | | | | | | | | | | | | | | The source context is not prepended to the value of the `stack` property when the source map is not enabled. Rather than prepending the error source context to the value of the `stack` property unconditionally, this patch aligns the behavior and only prints the source context when the error is not handled by userland (e.g. fatal errors). Also, this patch fixes that when source-map support is enabled, the error source context is not pointing to where the error was thrown. PR-URL: https://github.com/nodejs/node/pull/43875 Fixes: https://github.com/nodejs/node/issues/43186 Fixes: https://github.com/nodejs/node/issues/41541 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* lib,src: add source map support for global evallegendecas2022-07-111-0/+46
| | | | | | | | | | Dynamic sources with FunctionConstructor is not supported yet as V8 prepends lines to the sources which makes the stack line number incorrect. PR-URL: https://github.com/nodejs/node/pull/43428 Refs: https://github.com/nodejs/node/issues/43047 Reviewed-By: Ben Coe <bencoe@gmail.com>
* benchmark: fix output regressionBrian White2022-07-081-6/+8
| | | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/43628 PR-URL: https://github.com/nodejs/node/pull/43635 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* benchmark: fix fork detectionPaolo Insogna2022-06-291-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/43601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* benchmark: forcefully close processesPaolo Insogna2022-06-271-1/+7
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/43557 Fixes: https://github.com/nodejs/build/issues/2968 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* crypto: don't disable TLS 1.3 without suitesAdam Majer2022-06-274-3/+8
| | | | | | | | | | | | | | | | | | | In the manual page, there is a statement that ciphersuites contain explicit default settings - all TLS 1.3 ciphersuites enabled. In node, we assume that an empty setting mean no ciphersuites and we disable TLS 1.3. A correct approach to disabling TLS 1.3 is to disable TLS 1.3 and by not override the default ciphersuits with an empty string. So, only override OpenSSL's TLS 1.3 ciphersuites with an explicit list of ciphers. If none are acceptable, the correct approach is to disable TLS 1.3 instead elsewhere. Fixes: https://github.com/nodejs/node/issues/43419 PR-URL: https://github.com/nodejs/node/pull/43427 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>
* benchmark: add node-error benchmarkRafaelGSS2022-05-302-0/+35
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/43077 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* perf_hooks: add PerformanceResourceTimingRafaelGSS2022-05-131-0/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | perf_hooks: create clearResourceTimings perf_hooks: add resourcetiming test parallel perf_hooks: add markResourceTiming perf_hooks: fix observable when using resource perf_hooks: fix observable when using resource perf_hooks: add class comments perf_hooks: add PerformanceResourceTiming perf_hooks: create clearResourceTimings perf_hooks: add resourcetiming test parallel perf_hooks: add markResourceTiming perf_hooks: fix observable when using resource perf_hooks: fix observable when using resource perf_hooks: add class comments perf_hooks: add Resource Timing documentation benchmark: measure resource timing module perf_hooks: add check avoiding new PerformanceResourceTiming perf_hooks: adjust doc PR-URL: https://github.com/nodejs/node/pull/42725 Fixes: https://github.com/nodejs/undici/issues/952 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* benchmark: fix misc/startup failureAntoine du Hamel2022-04-171-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42746 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
* http: refactor headersTimeout and requestTimeout logicPaolo Insogna2022-04-138-20/+24
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41263 Fixes: https://github.com/nodejs/node/issues/33440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: enable no-var ESLint rule for libRich Trott2022-04-041-1/+0
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42573 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* crypto: validate `this` value for `webcrypto.getRandomValues`Antoine du Hamel2022-02-261-5/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41760 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* benchmark: avoid input param manipulationMrJithil2022-02-051-4/+3
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41741 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: enable no-empty ESLint ruleRich Trott2022-02-051-1/+0
| | | | | | | | | Refs: https://eslint.org/docs/rules/no-empty PR-URL: https://github.com/nodejs/node/pull/41831 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
View Lorry Controller Status