benchmark: use let instead of var

Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.

PR-URL: https://github.com/nodejs/node/pull/31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

8 files changed, 17 insertions, 18 deletions

diff --git a/benchmark/streams/creation.js b/benchmark/streams/creation.js
index 46a0a54790..760ab5c89d 100644
--- a/benchmark/streams/creation.js
+++ b/benchmark/streams/creation.js
@@ -13,14 +13,13 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, kind }) {
-  var i = 0;
   switch (kind) {
     case 'duplex':
       new Duplex({});
       new Duplex();
 
       bench.start();
-      for (; i < n; ++i)
+      for (let i = 0; i < n; ++i)
         new Duplex();
       bench.end(n);
       break;
@@ -29,7 +28,7 @@ function main({ n, kind }) {
       new Readable();
 
       bench.start();
-      for (; i < n; ++i)
+      for (let i = 0; i < n; ++i)
         new Readable();
       bench.end(n);
       break;
@@ -38,7 +37,7 @@ function main({ n, kind }) {
       new Writable();
 
       bench.start();
-      for (; i < n; ++i)
+      for (let i = 0; i < n; ++i)
         new Writable();
       bench.end(n);
       break;
@@ -47,7 +46,7 @@ function main({ n, kind }) {
       new Transform();
 
       bench.start();
-      for (; i < n; ++i)
+      for (let i = 0; i < n; ++i)
         new Transform();
       bench.end(n);
       break;
diff --git a/benchmark/streams/pipe-object-mode.js b/benchmark/streams/pipe-object-mode.js
index d52b223878..33588819f0 100644
--- a/benchmark/streams/pipe-object-mode.js
+++ b/benchmark/streams/pipe-object-mode.js
@@ -12,7 +12,7 @@ function main({ n }) {
   const r = new Readable({ objectMode: true });
   const w = new Writable({ objectMode: true });
 
-  var i = 0;
+  let i = 0;
 
   r._read = () => r.push(i++ === n ? null : b);
   w._write = (data, enc, cb) => cb();
diff --git a/benchmark/streams/pipe.js b/benchmark/streams/pipe.js
index 4baeeb2d2e..0df1afdbe1 100644
--- a/benchmark/streams/pipe.js
+++ b/benchmark/streams/pipe.js
@@ -12,7 +12,7 @@ function main({ n }) {
   const r = new Readable();
   const w = new Writable();
 
-  var i = 0;
+  let i = 0;
 
   r._read = () => r.push(i++ === n ? null : b);
   w._write = (data, enc, cb) => cb();
diff --git a/benchmark/streams/readable-bigread.js b/benchmark/streams/readable-bigread.js
index c3cff3d933..1bd1dab4ed 100644
--- a/benchmark/streams/readable-bigread.js
+++ b/benchmark/streams/readable-bigread.js
@@ -14,8 +14,8 @@ function main({ n }) {
   s._read = noop;
 
   bench.start();
-  for (var k = 0; k < n; ++k) {
-    for (var i = 0; i < 1e4; ++i)
+  for (let k = 0; k < n; ++k) {
+    for (let i = 0; i < 1e4; ++i)
       s.push(b);
     while (s.read(128));
   }
diff --git a/benchmark/streams/readable-bigunevenread.js b/benchmark/streams/readable-bigunevenread.js
index 95a4139c06..684986a778 100644
--- a/benchmark/streams/readable-bigunevenread.js
+++ b/benchmark/streams/readable-bigunevenread.js
@@ -14,8 +14,8 @@ function main({ n }) {
   s._read = noop;
 
   bench.start();
-  for (var k = 0; k < n; ++k) {
-    for (var i = 0; i < 1e4; ++i)
+  for (let k = 0; k < n; ++k) {
+    for (let i = 0; i < 1e4; ++i)
       s.push(b);
     while (s.read(106));
   }
diff --git a/benchmark/streams/readable-boundaryread.js b/benchmark/streams/readable-boundaryread.js
index 835c7d18b5..edc90d04de 100644
--- a/benchmark/streams/readable-boundaryread.js
+++ b/benchmark/streams/readable-boundaryread.js
@@ -10,14 +10,14 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, type }) {
   const s = new Readable();
-  var data = 'a'.repeat(32);
+  let data = 'a'.repeat(32);
   if (type === 'buffer')
     data = Buffer.from(data);
   s._read = function() {};
 
   bench.start();
-  for (var k = 0; k < n; ++k) {
-    for (var i = 0; i < 1e4; ++i)
+  for (let k = 0; k < n; ++k) {
+    for (let i = 0; i < 1e4; ++i)
       s.push(data);
     while (s.read(32));
   }
diff --git a/benchmark/streams/readable-readall.js b/benchmark/streams/readable-readall.js
index 3c177ec4c3..d14fd77565 100644
--- a/benchmark/streams/readable-readall.js
+++ b/benchmark/streams/readable-readall.js
@@ -14,8 +14,8 @@ function main({ n }) {
   s._read = noop;
 
   bench.start();
-  for (var k = 0; k < n; ++k) {
-    for (var i = 0; i < 1e4; ++i)
+  for (let k = 0; k < n; ++k) {
+    for (let i = 0; i < 1e4; ++i)
       s.push(b);
     while (s.read());
   }
diff --git a/benchmark/streams/readable-unevenread.js b/benchmark/streams/readable-unevenread.js
index 690f1f4208..9da8410131 100644
--- a/benchmark/streams/readable-unevenread.js
+++ b/benchmark/streams/readable-unevenread.js
@@ -14,8 +14,8 @@ function main({ n }) {
   s._read = noop;
 
   bench.start();
-  for (var k = 0; k < n; ++k) {
-    for (var i = 0; i < 1e4; ++i)
+  for (let k = 0; k < n; ++k) {
+    for (let i = 0; i < 1e4; ++i)
       s.push(b);
     while (s.read(12));
   }