diff options
author | MrJithil <jithil@outlook.com> | 2022-01-29 11:20:26 +0530 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2022-02-05 08:26:37 -0800 |
commit | 217acb9036f39ea6088cee75f70f11602997e15f (patch) | |
tree | 5a2e26905e723fa66a021109ffaa3299b616f4f0 /benchmark/assert | |
parent | 913c125e98802b8de062b97da64f7292d7d3f7ad (diff) | |
download | node-new-217acb9036f39ea6088cee75f70f11602997e15f.tar.gz |
benchmark: avoid input param manipulation
PR-URL: https://github.com/nodejs/node/pull/41741
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'benchmark/assert')
-rw-r--r-- | benchmark/assert/deepequal-object.js | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js index a8c539426a..7418e2a745 100644 --- a/benchmark/assert/deepequal-object.js +++ b/benchmark/assert/deepequal-object.js @@ -24,8 +24,7 @@ function createObj(source, add = '') { } function main({ size, n, method, strict }) { - // TODO: Fix this "hack". `n` should not be manipulated. - n = Math.min(Math.ceil(n / size), 20); + const len = Math.min(Math.ceil(n / size), 20); const source = Array.apply(null, Array(size)); const actual = createObj(source); @@ -39,8 +38,8 @@ function main({ size, n, method, strict }) { const value2 = method.includes('not') ? expectedWrong : expected; bench.start(); - for (let i = 0; i < n; ++i) { + for (let i = 0; i < len; ++i) { fn(actual, value2); } - bench.end(n); + bench.end(len); } |