diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-04-14 21:59:21 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-04-18 10:19:40 -0700 |
| commit | 1e7f6b157133d89b841de9bbc3348c474717b83d (patch) | |
| tree | 2646c8c004919d9d566acc8a4cb045319ef4fbc3 /COLLABORATOR_GUIDE.md | |
| parent | 296f33101b9a4e52a02e60f5822acc26754f5c0a (diff) | |
| download | node-new-1e7f6b157133d89b841de9bbc3348c474717b83d.tar.gz | |
doc: run tests before landing changes
The Collaborator Guide suggests running tests after pushing changes to
the main repository. Tests should be run before then so move the
instructions earlier.
Instructions are also simplified and re-written to not exclude Windows.
PR-URL: https://github.com/nodejs/node/pull/12416
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index c49ba71430..c7939e6eac 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -445,6 +445,10 @@ commit logs, ensure that they are properly formatted, and add * The commit message text must conform to the [commit message guidelines](./CONTRIBUTING.md#step-3-commit). +Run tests (`make -j4 test` or `vcbuild test`). Even though there was a +successful continuous integration run, other changes may have landed on master +since then, so running the tests one last time locally is a good practice. + Time to push it: ```text @@ -463,11 +467,6 @@ your pull request shows the purple merged status then you should still add the "Landed in <commit hash>..<commit hash>" comment if you added multiple commits. -* `./configure && make -j8 test` - * `-j8` builds node in parallel with 8 threads. Adjust to the number - of cores or processor-level threads your processor has (or slightly - more) for best results. - ### I Just Made a Mistake * Ping a CTC member. |