delta/node-new.git/tools/test.py, branch devsnek-patch-1

test: add Actions annotation output

2020-08-07T03:07:49+00:00

It's possible to annotate failures in Actions by printing
"::error file={},line={},col={}::{message}". This methos is preferrable
over using a problem matcher because problem matchers only allow
single-line messages, whereas ::error allows multi-line messages.

PR-URL: https://github.com/nodejs/node/pull/34590
Reviewed-By: Rich Trott 
Reviewed-By: Richard Lau

tools: decrease timeout in test.py

2020-04-18T02:29:45+00:00

This fixes the following crash on Windows for me. I don't know
why this I only started to see this now, but anyway, the new timeout
value is still longer than a week and a half.

    File "tools/test.py", line 1725, in 
        sys.exit(Main())
    File "tools/test.py", line 1701, in Main
        if RunTestCases(cases_to_run, options.progress, \
          options.j, options.flaky_tests):
    File "tools/test.py", line 923, in RunTestCases
        return progress.Run(tasks)
    File "tools/test.py", line 145, in Run
        thread.join(timeout=10000000)
    File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \
      lib\threading.py", line 1015, in join
        self._wait_for_tstate_lock(timeout=max(timeout, 0))
    File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \
      lib\threading.py", line 1027, in _wait_for_tstate_lock
        elif lock.acquire(block, timeout):
    OverflowError: timeout value is too large

PR-URL: https://github.com/nodejs/node/pull/32868
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Zeyu Yang 

Reviewed-By: Bartosz Sosnowski

test: add extended embedder cctest

2020-03-21T09:58:28+00:00

Add an embedder cctest that also covers a multi-Environment situation,
including worker_threads-style inspector support.

Co-authored-by: Joyee Cheung 

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

test: fix unit test logging with python3

2020-01-08T15:43:55+00:00

A logfile must be opened as a text file and encoding is specified.
Then it can accept a string. Current behaviour we get,

 Message: 'ok 2834 sequential/test-worker-prof'
 Arguments: ()
 --- Logging error ---
 Traceback (most recent call last):
   File "/usr/lib64/python3.7/logging/__init__.py", line 1037, in emit
     stream.write(msg + self.terminator)
 TypeError: a bytes-like object is required, not 'str'
 Call stack:
   File "tools/test.py", line 1734, in 
     sys.exit(Main())
   File "tools/test.py", line 1710, in Main
     if RunTestCases(cases_to_run, options.progress, options.j, options.flaky_tests):
   File "tools/test.py", line 933, in RunTestCases
     return progress.Run(tasks)
   File "tools/test.py", line 141, in Run
     self.RunSingle(False, 0)
   File "tools/test.py", line 202, in RunSingle
     self.HasRun(output)
   File "tools/test.py", line 365, in HasRun
     logger.info('  ---')

PR-URL: https://github.com/nodejs/node/pull/31156
Reviewed-By: Christian Clauss 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott 
Reviewed-By: Daijiro Wachi

tools: fix Python 3 deprecation warning in test.py

2019-11-03T16:56:00+00:00

PR-URL: https://github.com/nodejs/node/pull/30208
Reviewed-By: Christian Clauss 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: David Carlier

test: fix test runner for Python 3 on Windows

2019-10-20T14:06:39+00:00

Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: https://github.com/nodejs/node/pull/30023
Reviewed-By: Richard Lau 
Reviewed-By: Christian Clauss 
Reviewed-By: Luigi Pinca

tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE

2019-10-13T20:41:25+00:00

PR-URL: https://github.com/nodejs/node/pull/29956
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott

test: use unique tmpdirs for each test

2019-08-11T02:21:26+00:00

Tests can leave processes running blocking the tmpdir. This does not
yet prevent tests from doing that, but prevents failures on
subsequent tests.

PR-URL: https://github.com/nodejs/node/pull/28858
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

test: fix pty test hangs on aix

2019-07-14T22:12:38+00:00

Some pty tests persistently hung on the AIX CI buildbots. Fix that by
adding a helper script that properly sets up the pty before spawning
the script under test.

On investigation I discovered that the test runner hung when it tried
to close the slave pty's file descriptor, probably due to a bug in
AIX's pty implementation. I could reproduce it with a short C program.
The test runner also leaked file descriptors to the child process.

I couldn't convince python's `subprocess.Popen()` to do what I wanted
it to do so I opted to move the logic to a helper script that can do
fork/setsid/etc. without having to worry about stomping on state in
tools/test.py.

In the process I also uncovered some bugs in the pty module of the
python distro that ships with macOS 10.14, leading me to reimplement
a sizable chunk of the functionality of that module.

And last but not least, of course there are differences between ptys
on different platforms and the helper script has to paper over that.
Of course.

Really, this commit took me longer to put together than I care to admit.

Caveat emptor: this commit takes the hacky ^D feeding to the slave out
of tools/test.py and puts it in the *.in input files. You can also feed
other control characters to tests, like ^C or ^Z, simply by inserting
them into the corresponding input file. I think that's nice.

Fixes: https://github.com/nodejs/build/issues/1820
Fixes: https://github.com/nodejs/node/issues/28489

PR-URL: https://github.com/nodejs/node/pull/28600
Reviewed-By: Richard Lau 
Reviewed-By: Sam Roberts 
Reviewed-By: Anna Henningsen

tools: python: ignore instead of select flake8 rules

2019-04-14T00:33:06+00:00

PR-URL: https://github.com/nodejs/node/pull/25614
Reviewed-By: Sakthipriyan Vairamani