delta/node-new.git/tools/cpplint.py, branch pull-request-doc-updates

tools: refloat Node.js patches to cpplint.py

2019-01-30T23:19:52+00:00

* Preserve 3 node-core checks
* Preserve patch to `FileInfo.RepositoryName`
* Remove TAP to logfile (unused)

PR-URL: https://github.com/nodejs/node/pull/25771
Fixes: https://github.com/nodejs/node/issues/25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ben Noordhuis

tools: bump cpplint.py to 3d8f6f876d

2019-01-30T23:19:45+00:00

PR-URL: https://github.com/nodejs/node/pull/25771
Fixes: https://github.com/nodejs/node/issues/25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ben Noordhuis

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

tools: fix cpplint --quiet option

2018-10-01T08:35:33+00:00

Currently, the --quiet option for cpplint will generate the following
error:
$ tools/cpplint.py  --quiet src/node.cc
Traceback (most recent call last):
  File "tools/cpplint.py", line 6529, in 
    main()
  File "tools/cpplint.py", line 6497, in main
    filenames = ParseArguments(sys.argv[1:])
  File "tools/cpplint.py", line 6437, in ParseArguments
    logger.addHandler(logging.FileHandler(val, mode='wb'))
  File "/python2.7/logging/__init__.py", line 911, in __init__
    StreamHandler.__init__(self, self._open())
  File "/python2.7/logging/__init__.py", line 941, in _open
    stream = open(self.baseFilename, self.mode)
IOError: [Errno 21] Is a directory: '/Users/danielbevenius/work/nodejs/node

This commit moves the FileHandler that currently exists in the quiet
option to the logfile clause. It looks like this issue came about when
merging in commit fee4d3ab90365aaff0d3469076c7ef8a3a91bc79 ("tools:
merge custom cpplint with cpplint v1.3.0").

PR-URL: https://github.com/nodejs/node/pull/23075
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung

tools: merge custom cpplint with cpplint v1.3.0

2018-09-18T05:56:56+00:00

Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with
our customized version to enable better IDE/editor integration.

Made file executable.

PR-URL: https://github.com/nodejs/node/pull/22864
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

tools: update cpplint to check for inline headers

2018-07-29T13:43:00+00:00

Update cpplint.py to check for inline headers when the corresponding
header is already included.

PR-URL: https://github.com/nodejs/node/pull/21521
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

tools: define xrange() in Python 3

2018-07-27T19:18:53+00:00

__xrange()__ was removed in Python 3 in favor of __range()__.
This PR ensures similar functionality on both Python 2 and Python 3.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150
(https://github.com/nodejs/node/pull/21942).

PR-URL: https://github.com/nodejs/node/pull/21945
Reviewed-By: Anna Henningsen 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell

src, tools: add check for left leaning pointers

2018-06-07T03:46:51+00:00

This commit adds a rule to cpplint to check that pointers in the code
base lean to the left and not right, and also fixes the violations
reported.

PR-URL: https://github.com/nodejs/node/pull/21010
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

tools: make C++ linter reject `template<`

2018-05-14T16:09:24+00:00

This one is more or less just for me. :)

PR-URL: https://github.com/nodejs/node/pull/20675
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ruben Bridgewater

tools: add cpplint rule for NULL usage

2017-12-01T06:45:05+00:00

This commit is a suggestion for adding a rule for NULL usages in the
code base. This will currently report a number of errors which could be
ignored using // NOLINT (readability/null_usage)

PR-URL: https://github.com/nodejs/node/pull/17373
Reviewed-By: Jon Moss 
Reviewed-By: Anna Henningsen 
Reviewed-By: Timothy Gu 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Tobias Nießen