delta/node-new.git/tools/cpplint.py, branch Ninja.py-StringIO

tools: move cpplint configuration to .cpplint

2019-04-08T12:30:29+00:00

PR-URL: https://github.com/nodejs/node/pull/27098
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius

tools: refloat 4 Node.js patches to cpplint.py

2019-04-08T12:30:24+00:00

* Add 3 Node.js checks
* Adjest cpplint.py header rules to Node.js convention

Cherry-pick 12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: https://github.com/nodejs/node/pull/17373
    Reviewed-By: Jon Moss 
    Reviewed-By: Anna Henningsen 
    Reviewed-By: Timothy Gu 
    Reviewed-By: Colin Ihrig 
    Reviewed-By: Michael Dawson 
    Reviewed-By: Sakthipriyan Vairamani 
    Reviewed-By: Tobias Nießen 

Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b

Cherry-pick fc81e801913de3e3f3c0c8e26c105f983a74e539
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: https://github.com/nodejs/node/pull/21521
    Reviewed-By: Ben Noordhuis 
    Reviewed-By: James M Snell 

Refs: https://github.com/nodejs/node/commit/fc81e801913de3e3f3c0c8e26c105f983a74e539

Cherry-pick cbc3dd997eb90d629d1b9912b7a5a40eb82343df
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: https://github.com/nodejs/node/pull/21010
    Reviewed-By: Ben Noordhuis 
    Reviewed-By: Anna Henningsen 
    Reviewed-By: Ruben Bridgewater 
    Reviewed-By: James M Snell 

Refs: https://github.com/nodejs/node/commit/cbc3dd997eb90d629d1b9912b7a5a40eb82343df

Cherry-pick 902998190a55d6915b881936f6dd5b6e9cca6ad8
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: https://github.com/nodejs/node/pull/26306
    Reviewed-By: Gireesh Punathil 

Refs: https://github.com/nodejs/node/commit/902998190a55d6915b881936f6dd5b6e9cca6ad8

PR-URL: https://github.com/nodejs/node/pull/27098
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius

tools: bump cpplint.py to 1.4.4

2019-04-08T12:30:18+00:00

Refs: https://github.com/cpplint/cpplint/releases/tag/1.4.4

PR-URL: https://github.com/nodejs/node/pull/27098
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius

src: add NOLINT to js_native_.*

2019-04-05T12:59:00+00:00

* add filter to not lint NOLINT rules

PR-URL: https://github.com/nodejs/node/pull/26884
Reviewed-By: Refael Ackermann

tools: fix cpplint.py header rules

2019-03-12T13:56:59+00:00

THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil

lib: fix a few minor issues flagged by lgtm

2019-02-06T16:09:29+00:00

* Confusing (but correct) regex using `A-z` character range by
  accident
* Add the status argument to afterShutdown

PR-URL: https://github.com/nodejs/node/pull/25873
Reviewed-By: Refael Ackermann 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts

tools: refloat Node.js patches to cpplint.py

2019-01-30T23:19:52+00:00

* Preserve 3 node-core checks
* Preserve patch to `FileInfo.RepositoryName`
* Remove TAP to logfile (unused)

PR-URL: https://github.com/nodejs/node/pull/25771
Fixes: https://github.com/nodejs/node/issues/25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ben Noordhuis

tools: bump cpplint.py to 3d8f6f876d

2019-01-30T23:19:45+00:00

PR-URL: https://github.com/nodejs/node/pull/25771
Fixes: https://github.com/nodejs/node/issues/25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ben Noordhuis

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

tools: fix cpplint --quiet option

2018-10-01T08:35:33+00:00

Currently, the --quiet option for cpplint will generate the following
error:
$ tools/cpplint.py  --quiet src/node.cc
Traceback (most recent call last):
  File "tools/cpplint.py", line 6529, in 
    main()
  File "tools/cpplint.py", line 6497, in main
    filenames = ParseArguments(sys.argv[1:])
  File "tools/cpplint.py", line 6437, in ParseArguments
    logger.addHandler(logging.FileHandler(val, mode='wb'))
  File "/python2.7/logging/__init__.py", line 911, in __init__
    StreamHandler.__init__(self, self._open())
  File "/python2.7/logging/__init__.py", line 941, in _open
    stream = open(self.baseFilename, self.mode)
IOError: [Errno 21] Is a directory: '/Users/danielbevenius/work/nodejs/node

This commit moves the FileHandler that currently exists in the quiet
option to the logfile clause. It looks like this issue came about when
merging in commit fee4d3ab90365aaff0d3469076c7ef8a3a91bc79 ("tools:
merge custom cpplint with cpplint v1.3.0").

PR-URL: https://github.com/nodejs/node/pull/23075
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung