delta/node-new.git/test, branch try_Python3_on_macOS

worker: make terminate() resolve for unref’ed Workers

2019-09-09T20:21:37+00:00

Once `worker.terminate()` is called, the Worker instance will be
destroyed as soon as possible anyway, so in order to make
the Promise returned by `worker.terminate()` resolve always,
it should be okay to just call `.ref()` on it and keep the main
event loop alive temporarily.

PR-URL: https://github.com/nodejs/node/pull/29484
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum

test: improve test-worker-message-port-message-before-close

2019-09-09T20:19:42+00:00

Replace a wrong comment with a correct assertion and await all async
operations inside the async function.

PR-URL: https://github.com/nodejs/node/pull/29483
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

worker: prevent event loop starvation through MessagePorts

2019-09-09T20:18:41+00:00

Limit the number of messages processed without interruption on a
given `MessagePort` to prevent event loop starvation, but still
make sure that all messages are emitted that were already in the
queue when emitting began.

This aligns the behaviour better with the web.

Refs: https://github.com/nodejs/node/pull/28030

PR-URL: https://github.com/nodejs/node/pull/29315
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel

test: disable core dumps before running crash test

2019-09-09T04:19:35+00:00

The test spawns a subprocess with the `--abort-on-uncaught-exception`
flag and expects it to terminate with a SIGABRT signal.

On systems where core dumps are enabled, that actually generates an
unnecessary core dump. Set `ulimit -c 0` before spawning the subprocess.

Fixes: https://github.com/nodejs/node/issues/29286

PR-URL: https://github.com/nodejs/node/pull/29478
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier

test: permit test-signalwrap to work without test runner

2019-09-08T17:10:38+00:00

test/async-hooks/test-signalwrap.js passes with the test.py test runner
but fails if run directly with the `node` executable. Modify the test so
it passes in both cases.

PR-URL: https://github.com/nodejs/node/pull/28306
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen

http2: do not crash on stream listener removal w/ destroyed session

2019-09-08T04:15:24+00:00

Do not crash when the session is no longer available.

Fixes: https://github.com/nodejs/node/issues/29457

PR-URL: https://github.com/nodejs/node/pull/29459
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Minwoo Jung 
Reviewed-By: Colin Ihrig

src: make ELDHistogram a HandleWrap

2019-09-08T03:57:35+00:00

This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: https://github.com/nodejs/node/pull/29317
Reviewed-By: James M Snell

doc: prepare markdown files for more stringent blank-line linting

2019-09-07T14:07:25+00:00

PR-URL: https://github.com/nodejs/node/pull/29447
Reviewed-By: Michaël Zasso 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca

perf_hooks: ignore duplicated entries in observer

2019-09-07T14:04:19+00:00

PerformanceObserver should add to observing only unique entry types.

PR-URL: https://github.com/nodejs/node/pull/29442
Reviewed-By: David Carlier 
Reviewed-By: Minwoo Jung

esm: make dynamic import work in the REPL

2019-09-06T16:47:32+00:00

PR-URL: https://github.com/nodejs/node/pull/29437
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gus Caplan 
Reviewed-By: David Carlier