delta/node-new.git/test/sequential, branch test github.com: nodejs/node.git test: fix test-debugger-heap-profiler for workers 2021-08-09T10:11:56+00:00 Richard Lau rlau@redhat.com 2021-08-06T16:59:28+00:00 602fe4e83a572359c08c3a28fe054addb4252153 Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed. PR-URL: https://github.com/nodejs/node/pull/39687 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> 
Fix `sequential/test-debugger-heap-profiler` so that it can be run
in a worker thread. `process.chdir()` is not allowed in worker threads
but passing a current working directory into a spawned child process
is allowed.

PR-URL: https://github.com/nodejs/node/pull/39687
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
debugger: prevent simultaneous heap snapshots 2021-08-05T11:52:55+00:00 Rich Trott rtrott@gmail.com 2021-08-03T04:41:19+00:00 16a9ab142c804c90c1990eef01dc6116bc786d16 Fixes: https://github.com/nodejs/node/issues/39555 PR-URL: https://github.com/nodejs/node/pull/39638 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> 
Fixes: https://github.com/nodejs/node/issues/39555

PR-URL: https://github.com/nodejs/node/pull/39638
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
test: add test-debugger-breakpoint-exists 2021-08-01T14:24:36+00:00 Rich Trott rtrott@gmail.com 2021-07-29T03:56:11+00:00 42d31447d56418021d3b984a1ed2ada3dd49918a This adds test coverage to `unpackError()` in `lib/internal/debugger/inspect_client.js`. That function previously was untested. PR-URL: https://github.com/nodejs/node/pull/39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> 
This adds test coverage to `unpackError()` in
`lib/internal/debugger/inspect_client.js`. That function previously was
untested.

PR-URL: https://github.com/nodejs/node/pull/39570
Refs: https://github.com/nodejs/node-inspect/issues/101
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
debugger: indicate server is ending 2021-07-12T13:29:01+00:00 Rich Trott rtrott@gmail.com 2021-07-10T01:19:41+00:00 a518e4b871d39f0631beefc79cfa9dd81b82fe9f Currently, we say "listening" when we are ending the server. Change it to "ending". Fixes: https://github.com/nodejs/node/issues/39272 PR-URL: https://github.com/nodejs/node/pull/39334 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> 
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: https://github.com/nodejs/node/issues/39272

PR-URL: https://github.com/nodejs/node/pull/39334
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
test: move debugger test case to parallel 2021-07-10T00:04:07+00:00 Rich Trott rtrott@gmail.com 2021-07-07T17:51:29+00:00 6463adf183449b83d125a0e975c54f8bdf54d847 Move test case that does not require a predetermined port to parallel. PR-URL: https://github.com/nodejs/node/pull/39300 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> 
Move test case that does not require a predetermined port to parallel.

PR-URL: https://github.com/nodejs/node/pull/39300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
test: use common.PORT instead of hardcoded port number 2021-07-10T00:02:32+00:00 Rich Trott rtrott@gmail.com 2021-07-07T16:45:04+00:00 debdc1dbb6851a0c341d58efe50d34a79807278a PR-URL: https://github.com/nodejs/node/pull/39298 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> 
PR-URL: https://github.com/nodejs/node/pull/39298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: remove workaround code in debugger test 2021-07-06T04:17:55+00:00 Rich Trott rtrott@gmail.com 2021-07-02T13:44:15+00:00 12622c5f86fde7c878c7e4e7f441206cf0980457 Remove code that made a check more lenient to account for a known issue that is no longer reproducible. Refs: https://github.com/nodejs/node-inspect/issues/35 PR-URL: https://github.com/nodejs/node/pull/39238 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> 
Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: https://github.com/nodejs/node-inspect/issues/35

PR-URL: https://github.com/nodejs/node/pull/39238
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
test: remove checks for armv6 2021-07-05T02:56:07+00:00 Rich Trott rtrott@gmail.com 2021-06-26T15:40:27+00:00 62321267b05a8bb66915edc30587a421bcc82434 We no longer have armv6 in our regular CI. Remove checks. PR-URL: https://github.com/nodejs/node/pull/39162 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> 
We no longer have armv6 in our regular CI. Remove checks.

PR-URL: https://github.com/nodejs/node/pull/39162
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test: move test-debugger-address to parallel 2021-07-04T14:42:48+00:00 Rich Trott rtrott@gmail.com 2021-07-02T13:59:34+00:00 c2e6822153bad023ab7ebd30a6117dcc049e475c The test uses `--inspect=0` so it uses an OS-selected port rather than the default port. This means it can be run in the parallel directory. PR-URL: https://github.com/nodejs/node/pull/39236 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> 
The test uses `--inspect=0` so it uses an OS-selected port rather than
the default port. This means it can be run in the parallel directory.

PR-URL: https://github.com/nodejs/node/pull/39236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test: replace "inspector-cli" with "debugger" 2021-06-28T13:26:02+00:00 Rich Trott rtrott@gmail.com 2021-06-26T05:11:59+00:00 9cdac42f3d2d9d898b9a3df4805a12072fd1b7d1 When I moved node-inspect into core, I called a lot of things `inspector-cli` that really should have been `debugger`. This is the last of them to be renamed. PR-URL: https://github.com/nodejs/node/pull/39156 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> 
When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: https://github.com/nodejs/node/pull/39156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>