delta/node-new.git/test/sequential/test-inspector.js, branch test

test: prepare for consistent comma-dangle lint rule

2021-04-02T06:14:29+00:00

Make changes so that tests will pass when the comma-dangle settings
applied to the rest of the code base are also applied to tests.

PR-URL: https://github.com/nodejs/node/pull/37930
Reviewed-By: James M Snell 
Reviewed-By: Derek Lewis

test,doc,lib: adjust object literal newlines for lint rule

2021-01-27T00:49:18+00:00

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: https://github.com/nodejs/node/pull/37040
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel

inspector: do not hardcode Debugger.CallFrameId in tests

2020-10-13T00:30:24+00:00

Debugger.CallFrameId is defined as an opaque string [1].

Some tests currently hardcode the value, relying on
undocumented internal details of V8. This makes it hard
for V8 to change the internal representation.

We should instead use the reported call frame id from
the Debugger.paused event directly. This is how every
inspector client does it.

[1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId

PR-URL: https://github.com/nodejs/node/pull/35570
Reviewed-By: Aleksei Koziatinskii 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

test: make sure that inspector tests finish

2020-04-08T14:43:13+00:00

PR-URL: https://github.com/nodejs/node/pull/32673
Reviewed-By: Rich Trott 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

test: remove unnecessary --expose-internals flags

2019-10-10T18:59:31+00:00

PR-URL: https://github.com/nodejs/node/pull/29886
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: Richard Lau 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

test: correct assertion argument order

2018-10-15T13:34:45+00:00

This conforms assertions to follow the argument order of
asserted then actual, and adds more explicit messages
to describe assertion failures.

PR-URL: https://github.com/nodejs/node/pull/23618
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

test: improve assertion in test-inspector.js

2018-09-17T03:37:28+00:00

Remove an unecessary string literal from assert.strictEqual() call in
test-inspector.js. The string literal is printed instead of the value
that causes an error. Removing the string literal allows the value that
caused the error to be printed. This improves the troubleshooting
experience when the test fails due to that assertion.

PR-URL: https://github.com/nodejs/node/pull/22849
Reviewed-By: Teddy Katz 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig