delta/node-new.git/test/sequential/test-debug-prompt.js, branch cleanup-getnodeversion.py github.com: nodejs/node.git test: fix flaky test-debug-prompt 2018-07-16T05:50:16+00:00 Rich Trott rtrott@gmail.com 2018-07-15T17:52:36+00:00 df97126173918ad589c5ceb234204f66d0c5afac Be sure to send `.exit` only once to avoid spurious EPIPE and possibly other errors. Fixes: https://github.com/nodejs/node/issues/21724 PR-URL: https://github.com/nodejs/node/pull/21826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> 
Be sure to send `.exit` only once to avoid spurious EPIPE and possibly
other errors.

Fixes: https://github.com/nodejs/node/issues/21724

PR-URL: https://github.com/nodejs/node/pull/21826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
test: refactor test-debug-prompt 2017-09-13T20:12:57+00:00 Rich Trott rtrott@gmail.com 2017-09-02T00:30:10+00:00 a172b7c51ec31d18d055889048dd5432bdd01d55 * Use cleaner `process.stdin.write('.exit')` to exit the process rather than `proc.kill()`. * Move test to sequential. It uses the default port 9229. It will fail if another inspector test (or test using port 0) is already using that port. So it needs to be run sequentially rather than in parallel with other tests. (We haven't seen many failures with it yet because there aren't a lot of other inspector tests in parallel at this time.) PR-URL: https://github.com/nodejs/node/pull/15141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> 
* Use cleaner `process.stdin.write('.exit')` to exit the process rather
  than `proc.kill()`.
* Move test to sequential. It uses the default port 9229. It will fail
  if another inspector test (or test using port 0) is already using that
  port. So it needs to be run sequentially rather than in parallel with
  other tests. (We haven't seen many failures with it yet because there
  aren't a lot of other inspector tests in parallel at this time.)

PR-URL: https://github.com/nodejs/node/pull/15141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>