<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node-new.git/test/parallel, branch devsnek-patch-1</title>
<subtitle>github.com: nodejs/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/'/>
<entry>
<title>http2: add support for TypedArray to getUnpackedSettings</title>
<updated>2020-11-19T17:48:02+00:00</updated>
<author>
<name>Antoine du Hamel</name>
<email>duhamelantoine1995@gmail.com</email>
</author>
<published>2020-11-16T23:18:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=ad0a01caedbd792a7a62080439bf44ec27146798'/>
<id>ad0a01caedbd792a7a62080439bf44ec27146798</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/36141
Reviewed-By: Matteo Collina &lt;matteo.collina@gmail.com&gt;
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/36141
Reviewed-By: Matteo Collina &lt;matteo.collina@gmail.com&gt;
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: set abort-controller toStringTag</title>
<updated>2020-11-19T15:56:51+00:00</updated>
<author>
<name>Benjamin Gruenbaum</name>
<email>benjamingr@gmail.com</email>
</author>
<published>2020-11-14T11:46:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=d7bfa589420d089d48ae4e685bdbde446962a6d8'/>
<id>d7bfa589420d089d48ae4e685bdbde446962a6d8</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/36115
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;
Reviewed-By: Anna Henningsen &lt;anna@addaleax.net&gt;
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/36115
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;
Reviewed-By: Anna Henningsen &lt;anna@addaleax.net&gt;
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>http: add support for abortsignal to http.request</title>
<updated>2020-11-19T14:32:44+00:00</updated>
<author>
<name>Benjamin Gruenbaum</name>
<email>benjamingr@gmail.com</email>
</author>
<published>2020-11-09T10:51:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=2097ffd7cb590d4df7f1c30eef4de18037320b7c'/>
<id>2097ffd7cb590d4df7f1c30eef4de18037320b7c</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/36048
Reviewed-By: Anna Henningsen &lt;anna@addaleax.net&gt;
Reviewed-By: Denys Otrishko &lt;shishugi@gmail.com&gt;
Reviewed-By: Ricky Zhou &lt;0x19951125@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/36048
Reviewed-By: Anna Henningsen &lt;anna@addaleax.net&gt;
Reviewed-By: Denys Otrishko &lt;shishugi@gmail.com&gt;
Reviewed-By: Ricky Zhou &lt;0x19951125@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: add throws option to fs.f/l/statSync</title>
<updated>2020-11-18T21:19:33+00:00</updated>
<author>
<name>Andrew Casey</name>
<email>andrew.casey@microsoft.com</email>
</author>
<published>2020-06-03T01:18:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=3772cf56ae289e4cdc456e576eba43311bab24c8'/>
<id>3772cf56ae289e4cdc456e576eba43311bab24c8</id>
<content type='text'>
For consumers that aren't interested in *why* a `statSync` call failed,
allocating and throwing an exception is an unnecessary expense.  This PR
adds an option that will cause it to return `undefined` in such cases
instead.

As a motivating example, the JavaScript &amp; TypeScript language service
shared between Visual Studio and Visual Studio Code is stuck with
synchronous file IO for architectural and backward-compatibility
reasons.  It frequently needs to speculatively check for the existence
of files and directories that may not exist (and cares about file vs
directory, so `existsSync` is insufficient), but ignores file system
entries it can't access, regardless of the reason.

Benchmarking the language service is difficult because it's so hard to
get good coverage of both code bases and user behaviors, but, as a
representative metric, we measured batch compilation of a few hundred
popular projects (by star count) from GitHub and found that, on average,
we saved about 1-2% of total compilation time.  We speculate that the
savings could be even more significant in interactive (language service
or watch mode) scenarios, where the same (non-existent) files need to be
polled over and over again.  It's not a huge improvement, but it's a
very small change and it will affect a lot of users (and CI runs).

For reference, our measurements were against `v12.x` (3637a061a at the
time) on an Ubuntu Server desktop with an SSD.

PR-URL: https://github.com/nodejs/node/pull/33716
Reviewed-By: Denys Otrishko &lt;shishugi@gmail.com&gt;
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For consumers that aren't interested in *why* a `statSync` call failed,
allocating and throwing an exception is an unnecessary expense.  This PR
adds an option that will cause it to return `undefined` in such cases
instead.

As a motivating example, the JavaScript &amp; TypeScript language service
shared between Visual Studio and Visual Studio Code is stuck with
synchronous file IO for architectural and backward-compatibility
reasons.  It frequently needs to speculatively check for the existence
of files and directories that may not exist (and cares about file vs
directory, so `existsSync` is insufficient), but ignores file system
entries it can't access, regardless of the reason.

Benchmarking the language service is difficult because it's so hard to
get good coverage of both code bases and user behaviors, but, as a
representative metric, we measured batch compilation of a few hundred
popular projects (by star count) from GitHub and found that, on average,
we saved about 1-2% of total compilation time.  We speculate that the
savings could be even more significant in interactive (language service
or watch mode) scenarios, where the same (non-existent) files need to be
polled over and over again.  It's not a huge improvement, but it's a
very small change and it will affect a lot of users (and CI runs).

For reference, our measurements were against `v12.x` (3637a061a at the
time) on an Ubuntu Server desktop with an SSD.

PR-URL: https://github.com/nodejs/node/pull/33716
Reviewed-By: Denys Otrishko &lt;shishugi@gmail.com&gt;
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs: filehandle read now accepts object as argument</title>
<updated>2020-11-18T18:50:44+00:00</updated>
<author>
<name>Nikola Glavina</name>
<email>glavina.nikola5@gmail.com</email>
</author>
<published>2020-11-14T00:53:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=d05c271f175891c9eb390969a6e24ffadfc04eb3'/>
<id>d05c271f175891c9eb390969a6e24ffadfc04eb3</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/34180
Fixes: https://github.com/nodejs/node/issues/34176
Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options
Reviewed-By: Zeyu Yang &lt;himself65@outlook.com&gt;
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/34180
Fixes: https://github.com/nodejs/node/issues/34176
Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options
Reviewed-By: Zeyu Yang &lt;himself65@outlook.com&gt;
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: deflake test-http-destroyed-socket-write2</title>
<updated>2020-11-18T17:49:24+00:00</updated>
<author>
<name>Luigi Pinca</name>
<email>luigipinca@gmail.com</email>
</author>
<published>2020-11-14T17:46:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=e682814c8f2f51f6c4643a2c1d0e473994473c38'/>
<id>e682814c8f2f51f6c4643a2c1d0e473994473c38</id>
<content type='text'>
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: https://github.com/nodejs/node/pull/36120
Fixes: https://github.com/nodejs/node/issues/36081
Fixes: https://github.com/nodejs/node/issues/4066
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Ricky Zhou &lt;0x19951125@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: https://github.com/nodejs/node/pull/36120
Fixes: https://github.com/nodejs/node/issues/36081
Fixes: https://github.com/nodejs/node/issues/4066
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Ricky Zhou &lt;0x19951125@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: make test-http2-client-jsstream-destroy.js reliable</title>
<updated>2020-11-17T16:28:20+00:00</updated>
<author>
<name>Rich Trott</name>
<email>rtrott@gmail.com</email>
</author>
<published>2020-11-15T16:16:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=fff25a0714576f7f92c73111bab1c63219812da0'/>
<id>fff25a0714576f7f92c73111bab1c63219812da0</id>
<content type='text'>
Use events instead of setTimeout() calls.

Fixes: https://github.com/nodejs/node/issues/36078

PR-URL: https://github.com/nodejs/node/pull/36129
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;
Reviewed-By: Benjamin Gruenbaum &lt;benjamingr@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use events instead of setTimeout() calls.

Fixes: https://github.com/nodejs/node/issues/36078

PR-URL: https://github.com/nodejs/node/pull/36129
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;
Reviewed-By: Benjamin Gruenbaum &lt;benjamingr@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: add test for fs.read when offset key is null</title>
<updated>2020-11-17T16:26:07+00:00</updated>
<author>
<name>mayank agarwal</name>
<email>mayankagarwal44442@gmail.com</email>
</author>
<published>2020-11-01T16:50:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=0027aca332a780fdd06c39d92a8a139ca8d56e67'/>
<id>0027aca332a780fdd06c39d92a8a139ca8d56e67</id>
<content type='text'>
added test for uncovered if statement in lib/fs.js

PR-URL: https://github.com/nodejs/node/pull/35918
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
added test for uncovered if statement in lib/fs.js

PR-URL: https://github.com/nodejs/node/pull/35918
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>events: add max listener warning for EventTarget</title>
<updated>2020-11-16T09:48:18+00:00</updated>
<author>
<name>James M Snell</name>
<email>jasnell@gmail.com</email>
</author>
<published>2020-11-06T16:09:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=dc79f3f37caf6f25b8efee4623bec31e2c20f595'/>
<id>dc79f3f37caf6f25b8efee4623bec31e2c20f595</id>
<content type='text'>
Signed-off-by: James M Snell &lt;jasnell@gmail.com&gt;

PR-URL: https://github.com/nodejs/node/pull/36001
Fixes: https://github.com/nodejs/node/issues/35990
Reviewed-By: Benjamin Gruenbaum &lt;benjamingr@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: James M Snell &lt;jasnell@gmail.com&gt;

PR-URL: https://github.com/nodejs/node/pull/36001
Fixes: https://github.com/nodejs/node/issues/35990
Reviewed-By: Benjamin Gruenbaum &lt;benjamingr@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>promise: emit error on domain unhandled rejections</title>
<updated>2020-11-16T08:56:44+00:00</updated>
<author>
<name>Benjamin Gruenbaum</name>
<email>benjamingr@gmail.com</email>
</author>
<published>2020-11-11T12:52:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=cd3134029ebda16d37dcf6a10093bba9dff196e9'/>
<id>cd3134029ebda16d37dcf6a10093bba9dff196e9</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/36082
Reviewed-By: Ruben Bridgewater &lt;ruben@bridgewater.de&gt;
Reviewed-By: Yongsheng Zhang &lt;zyszys98@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/36082
Reviewed-By: Ruben Bridgewater &lt;ruben@bridgewater.de&gt;
Reviewed-By: Yongsheng Zhang &lt;zyszys98@gmail.com&gt;
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
