delta/node-new.git/test/parallel, branch cleanup-getnodeversion.py

bootstrap: add exception handling for profiler bootstrap

2019-09-23T10:04:20+00:00

Add exception handling for the case when profile is
not bootstrapped when coverage is enabled.

Fixes: https://github.com/nodejs/node/issues/29542

PR-URL: https://github.com/nodejs/node/pull/29552
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

stream: make _write() optional when _writev() is implemented

2019-09-23T02:07:35+00:00

When implementing _writev, _write should be optional.

PR-URL: https://github.com/nodejs/node/pull/29639
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Luigi Pinca

http: don't emit 'data' after 'error'

2019-09-23T01:08:20+00:00

PR-URL: https://github.com/nodejs/node/pull/28711
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca

stream: apply special logic in removeListener for readable.off()

2019-09-23T01:05:54+00:00

We have special logic in removeListener() which must apply
to off() as well.

PR-URL: https://github.com/nodejs/node/pull/29486
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

events: add support for EventTarget in once

2019-09-23T00:48:21+00:00

PR-URL: https://github.com/nodejs/node/pull/29498
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Minwoo Jung

stream: do not flush destroyed writable

2019-09-22T23:25:50+00:00

It doesn't make much sense to flush a stream which has been destroyed.

PR-URL: https://github.com/nodejs/node/pull/29028
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen

fs: remove unnecessary argument check

2019-09-22T23:23:02+00:00

Writable already assures that only Buffer's are passed to _write. Also
this is not the "correct" way to handle errors inside _write.

PR-URL: https://github.com/nodejs/node/pull/29043
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

timers: set _destroyed even if there are no destroy-hooks

2019-09-22T23:19:26+00:00

Required for other potential changes.

This should make it so we can always just check _destroyed to
check if a timer has been ended.

PR-URL: https://github.com/nodejs/node/pull/29595
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

stream: do not call _read() after destroy()

2019-09-22T22:55:15+00:00

PR-URL: https://github.com/nodejs/node/pull/29491
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jeremiah Senkpiel

stream: use more accurate end-of-stream writable and readable detection

2019-09-22T22:47:40+00:00

The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: https://github.com/nodejs/node/issues/29395
PR-URL: https://github.com/nodejs/node/pull/29409
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell