delta/node-new.git/test/parallel/test-vm-module-errors.js, branch cleanup-getnodeversion.py

test: test error when breakOnSigint is not a boolean for evaluate

2019-05-11T13:35:17+00:00

PR-URL: https://github.com/nodejs/node/pull/27503
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Trivikram Kamat

test: simplify vm-module-errors test

2019-04-10T00:52:41+00:00

Use `assert.rejects` to test error cases. This simplifies the test.

PR-URL: https://github.com/nodejs/node/pull/27123
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yuta Hiroto 
Reviewed-By: James M Snell

test: remove unused catch bindings

2018-11-06T15:59:18+00:00

PR-URL: https://github.com/nodejs/node/pull/24079
Reviewed-By: Sam Roberts 
Reviewed-By: Wyatt Preul

test: augment tests for SourceTextModule

2018-10-15T13:34:45+00:00

Adds tests for a few error conditions. Also, adds tests to make sure
the dynamically generated url is correct.

PR-URL: https://github.com/nodejs/node/pull/23573
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 

PR-URL: https://github.com/nodejs/node/pull/23572
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

test: adding test coverage for SourceTextModule.evaluate

2018-10-13T00:23:13+00:00

This checks that invalid option throws an error.

PR-URL: https://github.com/nodejs/node/pull/23595
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tiancheng "Timothy" Gu

vm: rename vm.Module to vm.SourceTextModule

2018-07-31T15:23:03+00:00

At the last TC39 meeting, a new type of Module Records backed by
JavaScript source called Dynamic Module Records was discussed, and
it is now at Stage 1. Regardless of whether that proposal makes it
all the way into the spec, SourceTextModule is indeed a more
descriptive and accurate name for what this class represents.

PR-URL: https://github.com/nodejs/node/pull/22007
Reviewed-By: Colin Ihrig 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Jan Krems 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Matteo Collina 
Reviewed-By: Michaël Zasso 
Reviewed-By: Yuta Hiroto 
Reviewed-By: James M Snell 
Reviewed-By: John-David Dalton 
Reviewed-By: Bradley Farias

test: make crashOnUnhandleRejection opt-out

2018-07-19T06:47:28+00:00

This commit removes `common.crashOnUnhandledRejection()` and adds
`common.disableCrashOnUnhandledRejection()`.

To reduce the risk of mistakes and make writing tests that involve
promises simpler, always install the unhandledRejection hook in tests
and provide a way to disable it for the rare cases where it's needed.

PR-URL: https://github.com/nodejs/node/pull/21849
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

test: add url type check in Module options

2018-02-10T00:20:08+00:00

The code coverage in `root/internal/vm/Module.js` lacked test coverage
for the url options paramter. The test adds a check to ensure error
is thrown.

PR-URL: https://github.com/nodejs/node/pull/18664
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Yuta Hiroto 
Reviewed-By: James M Snell

vm: flip Module#link's signature

2018-02-03T19:04:34+00:00

The specifier parameter is deemed to be more essential than
referencingModule. Flipping the parameter order allows developers to
write simple linker functions that only take in a specifier.

PR-URL: https://github.com/nodejs/node/pull/18471
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

vm: add modules

2018-01-31T01:00:57+00:00

Adds vm.Module, which wraps around ModuleWrap to provide an interface
for developers to work with modules in a more reflective manner.

Co-authored-by: Timothy Gu 
PR-URL: https://github.com/nodejs/node/pull/17560
Reviewed-By: Michaël Zasso 
Reviewed-By: Tiancheng "Timothy" Gu