delta/node-new.git/test/parallel/test-vm-module-basic.js, branch devsnek-patch-1

lib: remove ERR_INVALID_OPT_VALUE and ERR_INVALID_OPT_VALUE_ENCODING

2020-09-11T14:54:42+00:00

This will be a start to generalize all argument validation
errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more
specific errors.
The OPT errors didn't bring much to the errors as it's just another
variant of ARG error which is sometimes more confusing (some of our code
used OPT errors to denote just argument validation errors presumably
because of similarity of OPT to 'option' and not 'options-object')
and they don't specify the name of the options object where the invalid
value is located. Much better approach would be to just specify path
to the invalid value in the name of the value as it is done in this PR
(i.e. 'options.format', 'options.publicKey.type' etc)

Also since this decreases a variety of errors we have it'd be easier to
reuse validation code across the codebase.

Refs: https://github.com/nodejs/node/pull/31251
Refs: https://github.com/nodejs/node/pull/34070#discussion_r467251009
Signed-off-by: Denys Otrishko 

PR-URL: https://github.com/nodejs/node/pull/34682
Reviewed-By: Matteo Collina 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

test: use `.then(common.mustCall())` for all async IIFEs

2020-07-20T16:13:28+00:00

This makes sure that all async functions finish as expected.

PR-URL: https://github.com/nodejs/node/pull/34363
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

util: fix inspection of class instance prototypes

2020-05-25T17:20:48+00:00

To achieve this, some internal custom inspect functions had to be
changed. They relied upon the former behavior.

Signed-off-by: Ruben Bridgewater 

PR-URL: https://github.com/nodejs/node/pull/33449
Fixes: https://github.com/nodejs/node/issues/33419
Reviewed-By: Anto Aravinth 
Reviewed-By: Michaël Zasso 
Reviewed-By: Benjamin Gruenbaum

Revert "vm: add importModuleDynamically option to compileFunction"

2020-05-15T10:14:35+00:00

This reverts commit 74c393dd93cc0e461e3796fbcc09545fcacdecaf.

Fixes: https://github.com/nodejs/node/issues/33166

PR-URL: https://github.com/nodejs/node/pull/33364
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Beth Griggs 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: add support for TLA

2020-05-14T17:39:23+00:00

PR-URL: https://github.com/nodejs/node/pull/30370
Reviewed-By: Guy Bedford 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Myles Borins

vm: throw error when duplicated exportNames in SyntheticModule

2020-04-28T15:49:32+00:00

Fixes: https://github.com/nodejs/node/issues/32806

PR-URL: https://github.com/nodejs/node/pull/32810
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso

vm: add importModuleDynamically option to compileFunction

2020-04-25T14:49:53+00:00

Fixes: https://github.com/nodejs/node/issues/31860

PR-URL: https://github.com/nodejs/node/pull/32985
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

test: cover vm with negative tests

2019-12-22T05:25:23+00:00

Test the impossibility of creating
an abstract instance of the Module.
Test of SyntheticModule to throw exception
if invalid params in constructor

PR-URL: https://github.com/nodejs/node/pull/31028
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: David Carlier 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Rich Trott

vm: add Synthetic modules

2019-10-14T21:25:38+00:00

- Refactor vm.SourceTextModule (again)
- Add vm.Module abstract superclass
- Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records

PR-URL: https://github.com/nodejs/node/pull/29864
Reviewed-By: Guy Bedford