delta/node-new.git/test/parallel/test-string-decoder.js, branch cleanup-getnodeversion.py

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

test: fix uses of deprecated assert.fail with multiple args

2018-11-10T16:45:41+00:00

PR-URL: https://github.com/nodejs/node/pull/23673
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Refael Ackermann

string_decoder: fix number of replacement chars

2018-09-24T20:19:06+00:00

Fixes: https://github.com/nodejs/node/issues/22626

PR-URL: https://github.com/nodejs/node/pull/22709
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig

string_decoder: support typed array or data view

2018-09-17T15:48:44+00:00

Refs: https://github.com/nodejs/node/issues/1826
PR-URL: https://github.com/nodejs/node/pull/22562
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat

src: allow UTF-16 in generic StringBytes decode call

2018-09-03T20:33:42+00:00

This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: https://github.com/nodejs/node/issues/22358

PR-URL: https://github.com/nodejs/node/pull/22622
Reviewed-By: Tobias Nießen

test: improve code coverage for string decoder

2018-08-24T17:56:17+00:00

PR-URL: https://github.com/nodejs/node/pull/22306
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca

test: string-decorater.lastChar

2018-06-04T14:37:46+00:00

Added test for string-decorater.lastChar to improve coverage.

PR-URL: https://github.com/nodejs/node/pull/21084
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Lance Ball 
Reviewed-By: Trivikram Kamat

string_decoder: fix regressions

2018-02-13T13:03:23+00:00

There are libraries which invoke StringDecoder using .call and
.inherits, which directly conflicts with making StringDecoder
be a class which can only be invoked with the new keyword.
Revert to declaring it as a function.

StringDecoder#lastNeed was not defined, redefine it using
the new interface and fix StringDecoder#lastTotal.

PR-URL: https://github.com/nodejs/node/pull/18723
Refs: https://github.com/nodejs/node/pull/18537
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Evan Lucas 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tiancheng "Timothy" Gu

string_decoder: reimplement in C++

2018-02-10T13:38:56+00:00

Implement string decoder in C++. The perks are a decent speed boost
(for decoding, whereas creation show some performance degradation),
that this can now be used more easily to add native decoding support
to C++ streams and (arguably) more readable variable names.

PR-URL: https://github.com/nodejs/node/pull/18537
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

test: change test expectation for string decoder

2017-12-06T11:52:07+00:00

V8 has changed their invalid UTF-8 handling. See
https://chromium-review.googlesource.com/c/v8/v8/+/671020 for more info

PR-URL: https://github.com/nodejs/node/pull/16271
Reviewed-By: Ben Noordhuis 
Reviewed-By: Myles Borins