delta/node-new.git/test/parallel/test-stream-writev.js, branch cleanup-getnodeversion.py

stream: make _write() optional when _writev() is implemented

2019-09-23T02:07:35+00:00

When implementing _writev, _write should be optional.

PR-URL: https://github.com/nodejs/node/pull/29639
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Luigi Pinca

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

test: fix assert.strictEqual

2018-11-25T04:02:50+00:00

PR-URL: https://github.com/nodejs/node/pull/24619
Reviewed-By: Shingo Inoue 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil

test: improve to use template string

2018-01-17T00:50:02+00:00

PR-URL: https://github.com/nodejs/node/pull/18097
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

test: adjust indentation for stricter linting

2017-07-27T16:24:20+00:00

ESLint 4.x has stricter linting than previous versions. We are currently
using the legacy indentation rules in the test directory. This commit
changes the indentation of files to comply with the stricter 4.x linting
and enable stricter linting in the test directory.

PR-URL: https://github.com/nodejs/node/pull/14431
Reviewed-By: Refael Ackermann 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trevor Norris

lib,src: fix consistent spacing inside braces

2017-07-21T19:13:47+00:00

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: Timothy Gu 
Reviewed-By: James M Snell

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: add common.mustNotCall()

2017-02-06T19:07:55+00:00

This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: https://github.com/nodejs/node/pull/11152
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Yuta Hiroto

test: use common.fail() instead of assert(false)

2017-01-23T14:45:58+00:00

PR-URL: https://github.com/nodejs/node/pull/10899
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Italo A. Casas 
Reviewed-By: Luigi Pinca

test: s/assert.equal/assert.strictEqual/

2017-01-11T14:19:26+00:00

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Michaël Zasso 
Reviewed-By: Teddy Katz