delta/node-new.git/test/parallel/test-stream-transform-final.js, branch devsnek-patch-1

test: adjust comments for upcoming lint rule

2020-10-07T11:36:02+00:00

Enforce `//` for multiline comments. Some tests mixed and matched, and
at least one did so in a (to me) surprising way.

PR-URL: https://github.com/nodejs/node/pull/35485
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

stream: fix writable.end callback behavior

2020-07-01T16:18:04+00:00

Changes so that the end() callback behaves the same way in relation
to _final as write() does to _write/_writev.

PR-URL: https://github.com/nodejs/node/pull/34101
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen

stream: fix _final and 'prefinish' timing

2020-04-22T07:40:03+00:00

This PR fixes a few different things:

The timing of 'prefinish' depends on whether or not
_final is defined. In on case the event is emitted
synchronously with end() and otherwise asynchronously.

_final is currently unecessarily called asynchronously
which forces implementors to use 'prefinish' as a hack
to emulate synchronous behaviour. Furthermore, this hack
is subtly broken due to the above issue.

Refs: https://github.com/nodejs/node/issues/31401
Refs: https://github.com/nodejs/node/pull/32763#discussion_r407041983

PR-URL: https://github.com/nodejs/node/pull/32780
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

test: change var to const in parallel/test-stream-transform-final*

2019-11-15T07:38:43+00:00

PR-URL: https://github.com/nodejs/node/pull/30448
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Jiawen Geng 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

test: remove third argument from assert.strictEqual()

2018-08-03T02:29:53+00:00

In file test/parallel/test-stream-transform-final.js the ten calls to
assert.strictEqual() use a string literal as third argument. When
a AssertionError occurs, it reports the string literal and not the
first two arguments, so the third agrument is removed and made a
comment just above the call to assert.strictEqual().

PR-URL: https://github.com/nodejs/node/pull/22051
Reviewed-By: Rich Trott 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Jon Moss 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater

test: fix spelling in test case comments

2018-01-11T15:49:38+00:00

PR-URL: https://github.com/nodejs/node/pull/18018
Reviewed-By: Jon Moss 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Weijia Wang 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Yuta Hiroto

stream: add final method

2017-05-24T17:11:01+00:00

Adds the ability to for write streams to have an _final method which acts
similarly to the _flush method that transform streams have but is called before
the finish event is emitted and if asynchronous delays the stream from
finishing.  The `final` option may also be passed in order to set it.

PR-URL: https://github.com/nodejs/node/pull/12828
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Refael Ackermann