delta/node-new.git/test/parallel/test-stream-pipeline.js, branch Remove-Python-3-tests

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

test: split out http2 from test-stream-pipeline

2018-11-25T07:36:08+00:00

Splitting out the http2 portion of the test has a few benfits:

* We don't skip the rest of the tests if `node` is compiled without
  crypto.
* We can find out if the http2 portion of the test is responsible for
  the timeouts reported in issue 24456.

Refs: https://github.com/nodejs/node/issues/24456

PR-URL: https://github.com/nodejs/node/pull/24631
Reviewed-By: Refael Ackermann 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

test,stream: fix pipeline test so it runs well on Windows in older nodes

2018-08-24T09:14:44+00:00

This test is ported automatically in readable-stream, and it fails there
on Windows and older Node.js versions because of some bad interactions
between the code and the event loop on Windows.

See: https://github.com/nodejs/readable-stream/issues/353

PR-URL: https://github.com/nodejs/node/pull/22456
Reviewed-By: Mathias Buus 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

test: make crashOnUnhandleRejection opt-out

2018-07-19T06:47:28+00:00

This commit removes `common.crashOnUnhandledRejection()` and adds
`common.disableCrashOnUnhandledRejection()`.

To reduce the risk of mistakes and make writing tests that involve
promises simpler, always install the unhandledRejection hook in tests
and provide a way to disable it for the rare cases where it's needed.

PR-URL: https://github.com/nodejs/node/pull/21849
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

stream: make the pipeline callback mandatory

2018-06-07T23:24:39+00:00

Right now when not adding a callback to the pipeline it could cause
an uncaught exception if there is an error. Instead, just make the
callback mandatory as mostly done in all other Node.js callback APIs
so users explicitly have to decide what to do in such situations.

PR-URL: https://github.com/nodejs/node/pull/21054
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell

test: remove unref in http2 test

2018-06-07T13:41:36+00:00

The bug referenced in this TODO was fixed and this test no longer
requires this code to pass.

PR-URL: https://github.com/nodejs/node/pull/21145
Reviewed-By: Rich Trott

stream: ensure Stream.pipeline re-throws errors without callback

2018-05-31T09:22:54+00:00

Fixes an issue where Stream.pipeline wouldn't re-throw errors
on a stream if no callback was specified, thus swallowing
said errors.

Fixes: https://github.com/nodejs/node/issues/20303

PR-URL: https://github.com/nodejs/node/pull/20437
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina

stream: add pipeline and finished

2018-04-16T14:02:12+00:00

PR-URL: https://github.com/nodejs/node/pull/19828
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell