delta/node-new.git/test/parallel/test-require-json.js, branch devsnek-patch-1

test: use assert.throws() in test-require-json.js

2019-07-31T04:09:50+00:00

Use assert.throws() instead of try/catch.

PR-URL: https://github.com/nodejs/node/pull/28358
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

test: make test-require-json engine agnostic

2017-11-12T01:41:07+00:00

Remove reliance on V8-specific error message in test-require-json.

PR-URL: https://github.com/nodejs/node/pull/16272
Reviewed-By: Michaël Zasso 
Reviewed-By: Refael Ackermann 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Tobias Nießen

test: clarified assert message for test-require-json.js

2017-11-06T18:15:22+00:00

PR-URL: https://github.com/nodejs/node/pull/16807
Reviewed-By: Gireesh Punathil 
Reviewed-By: Rich Trott

test: begin normalizing fixtures use

2017-08-08T01:00:57+00:00

Adds a new `../common/fixtures' module to begin normalizing
`test/fixtures` use. Our test code is a bit inconsistent with
regards to use of the fixtures directory. Some code uses
`path.join()`, some code uses string concats, some other
code uses template strings, etc. In mnay cases, significant
duplication of code is seen when accessing fixture files, etc.

This updates many (but by no means all) of the tests in the
test suite to use the new consistent API. There are still
many more to update, which would make an excelent Code-n-Learn
exercise.

PR-URL: https://github.com/nodejs/node/pull/14332
Reviewed-By: Anna Henningsen 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso

test: fix RegExp nits

2017-06-21T00:40:27+00:00

* Remove needless RegExp flag

  In fixed case, `/g` flag is needless in the boolean context.

* Remove needless RegExp capturing

  Use non-capturing grouping or remove capturing completely when:

  * capturing is useless per se, e.g. in test() check;
  * captured groups are not used afterward at all;
  * some of the later captured groups are not used afterward.

* Use test, not match/exec in boolean context

  match() and exec() return a complicated object,
  unneeded in a boolean context.

* Do not needlessly repeat RegExp creation

  This commit takes RegExp creation out of cycles and other repetitions.

  As long as the RegExp does not use /g flag and match indices,
  we are safe here.

  In tests, this fix hardly gives a significant performance gain,
  but it increases clarity and maintainability,
  reassuring some RegExps to be identical.

  RegExp in functions are not taken out of their functions:
  while these functions are called many times
  and their RegExps are recreated with each call,
  the performance gain in test cases
  does not seem to be worth decreasing function self-dependency.

PR-URL: https://github.com/nodejs/node/pull/13770
Reviewed-By: Colin Ihrig

tools: add unescaped regexp dot rule to linter

2017-03-29T08:53:28+00:00

PR-URL: https://github.com/nodejs/node/pull/11834
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Teddy Katz 
Reviewed-By: Franziska Hinkelmann

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: use const instead of var in test-require-json.js

2016-12-05T03:07:49+00:00

PR-URL: https://github.com/nodejs/node/pull/9904
Reviewed-By: Colin Ihrig 
Reviewed-By: Myles Borins 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

lib,test: remove unneeded escaping of /

2016-11-10T00:40:38+00:00

The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

PR-URL: https://github.com/nodejs/node/pull/9485
Reviewed-By: Prince John Wesley 
Reviewed-By: Colin Ihrig 
Reviewed-By: Teddy Katz 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

tools: add eslint rule prefer-assert-methods

2016-09-20T23:35:39+00:00

PR-URL: https://github.com/nodejs/node/pull/8622
Reviewed-By: James M Snell 
Reviewed-By: Yorkie Liu 
Reviewed-By: Jackson Tian 
Reviewed-By: Johan Bergström 
Reviewed-By: Rich Trott 
Reviewed-By: Teddy Katz