delta/node-new.git/test/parallel/test-repl-function-definition-edge-case.js, branch devsnek-patch-1

repl: make console, module and require non-enumerable

2018-05-19T15:55:55+00:00

This aligns these globals with the regular context.

PR-URL: https://github.com/nodejs/node/pull/20717
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina

Revert "repl: refactor tests to not rely on timing"

2018-02-12T14:42:06+00:00

This reverts commit de848ac1e0483327a2ce8716c3f8567eaeacb660.

The commit broke multiline repl.

PR-URL: https://github.com/nodejs/node/pull/18715
Refs: https://github.com/nodejs/node/pull/17828
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Colin Ihrig

repl: refactor tests to not rely on timing

2018-02-10T13:19:54+00:00

Tests relying on synchronous timing have been migrated to use events.

PR-URL: https://github.com/nodejs/node/pull/17828
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso

test: remove common.noop

2017-07-03T18:39:35+00:00

This change removes `common.noop` from the Node.js internal testing
common module.

Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.

First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.

Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)

Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.

Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.

So, I propose removing it.

PR-URL: https://github.com/nodejs/node/pull/12822
Reviewed-By: Teddy Katz 
Reviewed-By: Timothy Gu 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

test: add common.noop, default for common.mustCall()

2017-03-26T19:47:15+00:00

Export a new common.noop no-operation function for general use.
Allow using common.mustCall() without a fn argument to simplify
test cases.

Replace various non-op functions throughout tests with common.noop

PR-URL: https://github.com/nodejs/node/pull/12027
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Richard Lau 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Teddy Katz 
Reviewed-By: Colin Ihrig 
Reviewed-By: Franziska Hinkelmann

test: fix repl-function-redefinition-edge-case

2017-03-15T00:27:22+00:00

`test/known_issues/test-repl-function-redefinition-edge-case.js` had
been introduced as a part of https://github.com/nodejs/node/pull/7624
but the meat of the test became fixed in
007386ee81ceeffd65c2248869717b0717db3e46. Despite that, the test
continued to fail since it was broken itself: there was a missing colon
in the expected output.

This commit adds the missing colon and moves the test from
`test/known_issues` to `test/parallel`.

PR-URL: https://github.com/nodejs/node/pull/11772
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig