delta/node-new.git/test/parallel/test-querystring.js, branch devsnek-patch-1

querystring: manage percent character at unescape

2020-09-04T03:43:39+00:00

Related: https://github.com/nodejs/node/issues/33892
Fixes: https://github.com/nodejs/node/issues/35012

PR-URL: https://github.com/nodejs/node/pull/35013
Reviewed-By: Joyee Cheung 
Reviewed-By: Shingo Inoue 
Reviewed-By: Rich Trott

querystring: fix stringify for empty array

2020-06-24T23:18:00+00:00

PR-URL: https://github.com/nodejs/node/pull/33918
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

benchmark,doc,lib: capitalize more comments

2019-03-27T16:20:06+00:00

PR-URL: https://github.com/nodejs/node/pull/26849
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

test: fix assertion arguments order

2018-10-15T13:33:11+00:00

There's no issue for this PR, it's a task at the Node+JS Code-n-Learn.

PR-URL: https://github.com/nodejs/node/pull/23584
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani

benchmark,lib,test,tools: use consistent quotes

2018-03-08T03:06:44+00:00

In preparation for a linting rule, use consistent quotation for
properties in objects.

PR-URL: https://github.com/nodejs/node/pull/19156
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Teddy Katz 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Roman Reiss

lint: move eslint to new plugin system

2018-02-20T19:13:22+00:00

PR-URL: https://github.com/nodejs/node/pull/18566
Reviewed-By: Joyee Cheung 
Reviewed-By: Roman Reiss