delta/node-new.git/test/parallel/test-process-chdir.js, branch devsnek-patch-1

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

process: improve cwd performance

2019-04-26T16:43:11+00:00

This caches the current working directory and only updates the variable
if `process.chdir()` is called.

PR-URL: https://github.com/nodejs/node/pull/27224
Reviewed-By: John-David Dalton 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso

src: disallow constructor behaviour for native methods

2019-03-21T11:14:26+00:00

Disallow constructor behaviour and setting up prototypes
for native methods that are not constructors (i.e. make
them behave like ES6 class methods).

PR-URL: https://github.com/nodejs/node/pull/26700
Reviewed-By: Gus Caplan 
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

test,tools: enable running tests under workers

2018-06-06T17:44:11+00:00

Enable running tests inside workers by passing `--worker`
to `tools/test.py`. A number of tests are marked as skipped,
or have been slightly altered to fit the different environment.

PR-URL: https://github.com/nodejs/node/pull/20876
Reviewed-By: Gireesh Punathil 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Shingo Inoue 
Reviewed-By: Matteo Collina 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Gus Caplan

process: migrate methods to throw errors with code

2018-04-26T17:42:55+00:00

Migrate some methods from node.cc to JS in order to properly throw
errors with codes.

PR-URL: https://github.com/nodejs/node/pull/19973
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

test: move tmpdir to submodule of common

2018-02-01T06:11:07+00:00

Move tmpdir functionality to its own module (common/tmpdir).

PR-URL: https://github.com/nodejs/node/pull/17856
Reviewed-By: James M Snell 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

test: fix RegExp nits

2017-06-21T00:40:27+00:00

* Remove needless RegExp flag

  In fixed case, `/g` flag is needless in the boolean context.

* Remove needless RegExp capturing

  Use non-capturing grouping or remove capturing completely when:

  * capturing is useless per se, e.g. in test() check;
  * captured groups are not used afterward at all;
  * some of the later captured groups are not used afterward.

* Use test, not match/exec in boolean context

  match() and exec() return a complicated object,
  unneeded in a boolean context.

* Do not needlessly repeat RegExp creation

  This commit takes RegExp creation out of cycles and other repetitions.

  As long as the RegExp does not use /g flag and match indices,
  we are safe here.

  In tests, this fix hardly gives a significant performance gain,
  but it increases clarity and maintainability,
  reassuring some RegExps to be identical.

  RegExp in functions are not taken out of their functions:
  while these functions are called many times
  and their RegExps are recreated with each call,
  the performance gain in test cases
  does not seem to be worth decreasing function self-dependency.

PR-URL: https://github.com/nodejs/node/pull/13770
Reviewed-By: Colin Ihrig

test: make tests cwd-independent

2017-05-05T11:39:48+00:00

PR-URL: https://github.com/nodejs/node/pull/12812
Reviewed-By: Alexey Orlenko 
Reviewed-By: Colin Ihrig 
Reviewed-By: Refael Ackermann 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

test: improve test-process-chdir

2017-04-24T17:31:28+00:00

remove typeError constructor and replace with regex string
to match typeError message

PR-URL: https://github.com/nodejs/node/pull/12589
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Cai 
Reviewed-By: James M Snell 
Reviewed-By: Gibson Fahnestock

test: use normalize() for unicode paths

2015-10-06T16:10:49+00:00

OS X 10.11 changed the unicode normalization form of certain code points
returned by system calls like getcwd() from NFC to NFD which made
results in this test failing.

The consensus of https://github.com/nodejs/node/issues/2165 is to delegate
the task of unicode normalization to the user, and work will continue to
document how to handle unicode in a form-sensitive file system.

PR-URL: https://github.com/nodejs/node/pull/3007
Fixes: https://github.com/nodejs/node/issues/2165
Reviewed-By: Johan Bergström 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Sakthipriyan Vairamani