delta/node-new.git/test/parallel/test-net-server-unref-persistent.js, branch cleanup-getnodeversion.py

benchmark,doc,lib: capitalize more comments

2019-03-27T16:20:06+00:00

PR-URL: https://github.com/nodejs/node/pull/26849
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt

test: add common.mustNotCall()

2017-02-06T19:07:55+00:00

This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: https://github.com/nodejs/node/pull/11152
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Yuta Hiroto

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: use const for all require() calls

2017-01-02T23:28:18+00:00

PR-URL: https://github.com/nodejs/node/pull/10550
Reviewed-By: Rich Trott

test: use mustCall() for simple flow tracking

2016-07-18T21:14:16+00:00

Many of the tests use variables to track when callback functions
are invoked or events are emitted. These variables are then
asserted on process exit. This commit replaces this pattern in
straightforward cases with common.mustCall(). This makes the
tests easier to reason about, leads to a net reduction in lines
of code, and uncovered a few bugs in tests. This commit also
replaces some callbacks that should never be called with
common.fail().

PR-URL: https://github.com/nodejs/node/pull/7753
Reviewed-By: Wyatt Preul 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ben Noordhuis

test: remove unnecessary assignments

2015-12-27T02:00:02+00:00

common.js needs to be loaded in all tests so that there is checking
for variable leaks and possibly other things. However, it does not
need to be assigned to a variable if nothing in common.js is referred
to elsewhere in the test.

PR-URL: https://github.com/nodejs/node/pull/4408
Reviewed-By: James M Snell

test: enable linting for tests

2015-05-19T19:21:27+00:00

Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis

net: make Server.prototype.unref() persistent

2015-02-21T01:37:10+00:00

Currently, the unref() method does not remember any state
if called before the server's handle has been created. This
commit adds state to track calls to ref() and unref().

PR-URL: https://github.com/iojs/io.js/pull/897
Reviewed-By: Evan Lucas 
Reviewed-By: Brendan Ashworth