delta/node-new.git/test/parallel/test-net-after-close.js, branch devsnek-patch-1

test: changed function to arrow function

2020-04-18T02:38:28+00:00

Convert callback functions that are anonymous
to arrow functions for better readability.
Also adjusted the `this` object in places where
that was required.

PR-URL: https://github.com/nodejs/node/pull/32875
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Ruben Bridgewater

test: add mustCall to test-net-after-close test

2019-04-29T21:59:47+00:00

PR-URL: https://github.com/nodejs/node/pull/27459
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Weijia Wang 
Reviewed-By: Yorkie Liu 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anto Aravinth 
Reviewed-By: Rich Trott

test: minor refactoring

2018-02-16T15:54:07+00:00

Add punctuation and comments about code that should not throw.
Also remove a obsolete test and refactor some tests.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

test: remove assert.doesNotThrow()

2018-02-16T15:53:47+00:00

There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: use const for all require() calls

2017-01-02T23:28:18+00:00

PR-URL: https://github.com/nodejs/node/pull/10550
Reviewed-By: Rich Trott

test: use mustCall() for simple flow tracking

2016-07-18T21:14:16+00:00

Many of the tests use variables to track when callback functions
are invoked or events are emitted. These variables are then
asserted on process exit. This commit replaces this pattern in
straightforward cases with common.mustCall(). This makes the
tests easier to reason about, leads to a net reduction in lines
of code, and uncovered a few bugs in tests. This commit also
replaces some callbacks that should never be called with
common.fail().

PR-URL: https://github.com/nodejs/node/pull/7753
Reviewed-By: Wyatt Preul 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ben Noordhuis

test: use random ports where possible

2016-06-11T02:30:55+00:00

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Rod Vagg

test: enable linting for tests

2015-05-19T19:21:27+00:00

Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis