delta/node-new.git/test/parallel/test-https-simple.js, branch devsnek-patch-1

test: simplify test-https-simple.js

2020-02-03T03:43:36+00:00

It had an unused `Agent` option (no such option exists), and some code
that common.must(Not)Call makes redundant.

PR-URL: https://github.com/nodejs/node/pull/31584
Reviewed-By: James M Snell 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

https: do not automatically use invalid servername

2019-06-17T09:58:26+00:00

Stop automatically setting servername in https.request() if the target
host is specified with an IP address. Doing so is invalid, and triggers
a deprecation warning. It is still possible to send an IP address as a
servername if its required, but it needs to be explicity configured, it
won't happen automatically.

PR-URL: https://github.com/nodejs/node/pull/28209
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Rich Trott 
Reviewed-By: Ruben Bridgewater

test: use fixtures module instead of common

2017-10-09T09:13:16+00:00

PR-URL: https://github.com/nodejs/node/pull/15925
Reviewed-By: Ruben Bridgewater

test: simplify test skipping

2017-07-04T09:41:49+00:00

* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann

test: refactoring test with common.mustCall

2017-05-07T21:15:31+00:00

PR-URL: https://github.com/nodejs/node/pull/12702
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen

test: reduce string concatenations

2017-05-05T14:39:05+00:00

PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann 
Reviewed-By: Gibson Fahnestock

test,lib,doc: use function declarations

2017-05-01T22:56:58+00:00

Replace function expressions with function declarations in preparation
for a lint rule requiring function declarations.

PR-URL: https://github.com/nodejs/node/pull/12711
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Gibson Fahnestock

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: s/assert.equal/assert.strictEqual/

2017-01-11T14:19:26+00:00

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Michaël Zasso 
Reviewed-By: Teddy Katz

test: use random ports where possible

2016-06-11T02:30:55+00:00

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Rod Vagg