delta/node-new.git/test/parallel/test-https-set-timeout-server.js, branch devsnek-patch-1

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

test: use fixtures in test-https-set-timeout-server

2017-10-13T01:32:32+00:00

Task to replace the common.fixturesDir with the usage
of the common.fixtures module. At Node.js Interactive.
First PR to Node.js. Yay!

PR-URL: https://github.com/nodejs/node/pull/15886
Reviewed-By: Luigi Pinca 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell

test: fix flaky http(s)-set-server-timeout tests

2017-07-25T19:18:03+00:00

The tests include a callback that might not be invoked but is wrapped in
common.mustCall(). Remove the common.mustCall() wrapper and add a
comment explaining that it should not be added.

Add a new test case that sets the timeout to 1ms and waits for both the
connection handler and the timeout handler to be invoked. This version
keeps the common.mustCall() wrapper intact around the connection handler
(although it's mostly semantic and not necessary for the test as the
test will certainly fail or time out if that handler isn't invoked).

PR-URL: https://github.com/nodejs/node/pull/14380
Fixes: https://github.com/nodejs/node/issues/11768
Reviewed-By: Colin Ihrig 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

test: fix flaky test-https-set-timeout-server

2017-07-11T17:09:06+00:00

Because of a race condition, connection listener may not be invoked if
test is run under load. Remove `common.mustCall()` wrapper from the
listener. Move the test to `parallel` because it now works under load.
Make similar change to http test to keep them in synch even though it is
much harder to trigger the race in http.

PR-URL: https://github.com/nodejs/node/pull/14134
Fixes: https://github.com/nodejs/node/issues/14133
Reviewed-By: Refael Ackermann 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Santiago Gimeno

test: move test to sequential for reliability

2017-04-30T20:40:16+00:00

test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: https://github.com/nodejs/node/pull/12704
Fixes: https://github.com/nodejs/node/issues/10130
Reviewed-By: Colin Ihrig 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Yuta Hiroto 
Reviewed-By: James M Snell 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Michael Dawson

test: add common.noop, default for common.mustCall()

2017-03-26T19:47:15+00:00

Export a new common.noop no-operation function for general use.
Allow using common.mustCall() without a fn argument to simplify
test cases.

Replace various non-op functions throughout tests with common.noop

PR-URL: https://github.com/nodejs/node/pull/12027
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Richard Lau 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Teddy Katz 
Reviewed-By: Colin Ihrig 
Reviewed-By: Franziska Hinkelmann

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: add common.mustNotCall()

2017-02-06T19:07:55+00:00

This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: https://github.com/nodejs/node/pull/11152
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Yuta Hiroto

test: s/assert.equal/assert.strictEqual/

2017-01-11T14:19:26+00:00

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Michaël Zasso 
Reviewed-By: Teddy Katz

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss