delta/node-new.git/test/parallel/test-https-connect-address-family.js, branch cleanup-getnodeversion.py

test: fix strictEqual() argument order

2018-10-26T03:22:58+00:00

PR-URL: https://github.com/nodejs/node/pull/23829
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

test: bypass dns for IPv6 net tests

2017-11-21T21:37:39+00:00

PR-URL: https://github.com/nodejs/node/pull/16976
Refs: https://github.com/nodejs/node/pull/16248
Reviewed-By: Joyee Cheung

test: configure certs in tests

2017-11-11T09:42:50+00:00

OpenSSL 1.1.0 disables anonymous ciphers unless building with
enable-weak-crypto. Avoid unnecessary dependencies on these ciphers in
tests.

PR-URL: https://github.com/nodejs/node/pull/16130
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rod Vagg

test: allow for different nsswitch.conf settings

2017-10-25T09:12:06+00:00

The motivation for this commit is that these two test fail on systems
that have different Name Service Switch configuration settings. A
concrete example of this is when using Red Hat Enterprise Linux (RHEL)
7.

If Name Service Switch is available on the operating system then it
might be configured differently (/etc/nsswitch.conf).
If the system is configured with no dns the error code will be
AI_AGAIN, but if there are more services after the dns entry, for
example some linux distributions skip a myhostname service by default
which would still produce the ENOTFOUND error.

This commit suggests checking for either ENOTFOUND or EAI_AGAIN to
accommodate systems like the ones described above. The references below
indicate that others have run, or are running, into this aswell.

Refs: https://github.com/nodejs/node/issues/12075
Refs: https://github.com/nodejs/help/issues/687
Refs: https://github.com/nodejs/node/issues/15825
PR-URL: https://github.com/nodejs/node/pull/16378
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis

lib,src: fix consistent spacing inside braces

2017-07-21T19:13:47+00:00

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: Timothy Gu 
Reviewed-By: James M Snell

test: simplify test skipping

2017-07-04T09:41:49+00:00

* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann

test: use dynamic port in test-https-connect-address-family

2017-05-12T13:37:12+00:00

Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12915
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig

test: handle IPv6 localhost issues within tests

2016-07-20T17:39:37+00:00

The issue of hosts that do not resolve `localhost` to `::1` is now
handled within the tests. Remove flaky status for
test-https-connect-address-family and test-tls-connect-address-family.

PR-URL: https://github.com/nodejs/node/pull/7766
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Michael Dawson 
Reviewed-By: Ben Noordhuis

test: fix flaky test-*-connect-address-family

2016-07-11T21:38:09+00:00

Skip tests if localhost does not resolve to ::1.

Fixes: https://github.com/nodejs/node/issues/7288
PR-URL: https://github.com/nodejs/node/pull/7605
Reviewed-By: Rod Vagg 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Sakthipriyan Vairamani

test: fix tests for non-crypto builds

2016-06-08T09:42:28+00:00

Fix running the tests when node was compiled without crypto
support. Some of these are cleanup after 52bae222a3a8480b2, where
common was used before it was required.

PR-URL: https://github.com/nodejs/node/pull/7056
Reviewed-By: Rich Trott 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Santiago Gimeno 
Reviewed-By: James M Snell