delta/node-new.git/test/parallel/test-https-client-get-url.js, branch cleanup-getnodeversion.py

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

test: fix assertion order

2018-10-15T13:34:45+00:00

PR-URL: https://github.com/nodejs/node/pull/23626
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ruben Bridgewater

test: replaced common.fixturesDir with readKey

2017-10-08T18:29:59+00:00

PR-URL: https://github.com/nodejs/node/pull/15933
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Gibson Fahnestock

lib,src: fix consistent spacing inside braces

2017-07-21T19:13:47+00:00

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: Timothy Gu 
Reviewed-By: James M Snell

test: simplify test skipping

2017-07-04T09:41:49+00:00

* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann

test: fix flaky test-https-client-get-url

2017-05-10T15:12:17+00:00

Fixed test-https-client-get-url by waiting on HTTPS GET requests
to finish before closing the server.

PR-URL: https://github.com/nodejs/node/pull/12876
Fixes: https://github.com/nodejs/node/issues/12873
Reviewed-By: Refael Ackermann 
Reviewed-By: Santiago Gimeno 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sakthipriyan Vairamani

test: reduce string concatenations

2017-05-05T14:39:05+00:00

PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann 
Reviewed-By: Gibson Fahnestock

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: s/assert.equal/assert.strictEqual/

2017-01-11T14:19:26+00:00

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Michaël Zasso 
Reviewed-By: Teddy Katz

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss