delta/node-new.git/test/parallel/test-https-agent.js, branch devsnek-patch-1

test: fix assertion argument order in test-https-agent.js

2019-07-03T20:17:41+00:00

PR-URL: https://github.com/nodejs/node/pull/28383
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell

test: use common/fixtures in test-https-agent

2017-10-13T00:29:12+00:00

PR-URL: https://github.com/nodejs/node/pull/15941
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

test: simplify test skipping

2017-07-04T09:41:49+00:00

* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann

test: reduce string concatenations

2017-05-05T14:39:05+00:00

PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann 
Reviewed-By: Gibson Fahnestock

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: improve test-https-agent.js

2016-09-16T23:05:06+00:00

On line 40: replace '==' with '==='

On line 52: replace 'assert.equal' with 'assert.strictEqual'

Added some comments.

Changed 'var' to 'const' where possible.

Replaced console.log(res.statusCode); with and assertion.

Rather than logging the https request status on every loop it will now
assert the https status is correct on every loop.

Changed the error listener to throw the error rather than log it.

PR-URL: https://github.com/nodejs/node/pull/8517
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

test: use random ports where possible

2016-06-11T02:30:55+00:00

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Rod Vagg

test: abstract skip functionality to common

2016-05-12T20:43:35+00:00

The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

PR-URL: https://github.com/nodejs/node/pull/6697
Reviewed-By: Rich Trott 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Fedor Indutny

test: mitigate flaky test-https-agent

2016-03-30T23:05:53+00:00

Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: https://github.com/nodejs/node/pull/5939
Fixes: https://github.com/nodejs/node/issues/5938
Refs: https://github.com/nodejs/node/issues/5184
Reviewed-By: Colin Ihrig 
Reviewed-By: Jeremiah Senkpiel