delta/node-new.git/test/parallel/test-http2-create-client-connect.js, branch test

test: prepare for consistent comma-dangle lint rule

2021-04-02T06:14:29+00:00

Make changes so that tests will pass when the comma-dangle settings
applied to the rest of the code base are also applied to tests.

PR-URL: https://github.com/nodejs/node/pull/37930
Reviewed-By: James M Snell 
Reviewed-By: Derek Lewis

test,benchmark: stop requiring URL and URLSearchParams

2021-01-18T21:44:33+00:00

Since the URL and URLSearchParams classes are available in the
global object, there is no need to require them from 'url'.

PR-URL: https://github.com/nodejs/node/pull/36927
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso

http2: wait for session socket writable end on close/destroy

2019-12-25T10:07:04+00:00

This slightly alters the behaviour of session close by first using
.end() on a session socket to finish writing the data and only then
calls .destroy() to make sure the Readable side is closed. This allows
the socket to finish transmitting data, receive proper FIN packet and
avoid ECONNRESET errors upon graceful close.

onStreamClose now directly calls stream.destroy() instead of
kMaybeDestroy because the latter will first check that the stream has
writableFinished set. And that may not be true as we have just
(synchronously) called .end() on the stream if it was not closed and
that doesn't give it enough time to finish. Furthermore there is no
point in waiting for 'finish' as the other party have already closed the
stream and we won't be able to write anyway.

This also changes a few tests to correctly handle graceful session
close. This includes:
* not reading request data (on client side)
* not reading push stream data (on client side)
* relying on socket.destroy() (on client) to finish server session
  due to the destroy of the socket without closing the server session.
  As the goaway itself is *not* a session close.

Added few 'close' event mustCall checks.

PR-URL: https://github.com/nodejs/node/pull/30854
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

test: use shorthand properties

2018-01-17T13:33:20+00:00

PR-URL: https://github.com/nodejs/node/pull/18105
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Weijia Wang 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

http2: cleanup Http2Stream/Http2Session destroy

2017-12-18T18:19:21+00:00

PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Anatoli Papirovski 

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

test: fix flaky test-http2-create-client-connect

2017-11-11T09:42:50+00:00

The first group of tests makes one more connection and leave the server
alive for longer. Otherwise the test is just catching that the server
has closed the socket, depending on timing.

This does not quite make the test pass yet, however. There are some
quirks with how the http2 code handles errors which actually affect
1.0.2 as well.

PR-URL: https://github.com/nodejs/node/pull/16130
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rod Vagg

test: update test to use fixtures module

2017-10-08T06:14:15+00:00

Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.

PR-URL: https://github.com/nodejs/node/pull/15955
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso

http2: make --expose-http2 flag a non-op

2017-09-28T05:01:06+00:00

Make the `http2` module always available.
The `--expose-http2` cli flag is made a non-op

PR-URL: https://github.com/nodejs/node/pull/15535
Reviewed-By: Matteo Collina 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Ruben Bridgewater

test: add crypto check to http2 tests

2017-08-08T22:30:46+00:00

When building --without-ssl and running the tests some of the http2 test
fail with the following error message:

internal/util.js:82
    throw new errors.Error('ERR_NO_CRYPTO');
    ^

Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
    at Object.assertCrypto (internal/util.js:82:11)
    at internal/http2/core.js:5:26
    at NativeModule.compile (bootstrap_node.js:586:7)
    at NativeModule.require (bootstrap_node.js:531:18)
    at http2.js:17:5
    at NativeModule.compile (bootstrap_node.js:586:7)
    at Function.NativeModule.require (bootstrap_node.js:531:18)
    at Function.Module._load (module.js:449:25)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)

This commit adds hasCrypto checks and skips the tests if there is no
crypto support.

PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

http2: add range support for respondWith{File|FD}

2017-08-04T19:56:45+00:00

* respondWithFD now supports optional statCheck
* respondWithFD and respondWithFile both support offset/length for
  range requests
* Fix linting nits following most recent update

PR-URL: https://github.com/nodejs/node/pull/14239
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matteo Collina