delta/node-new.git/test/parallel/test-http2-compat-socket.js, branch devsnek-patch-1

test: replace flag expose_internals to expose-internals

2020-04-02T16:28:23+00:00

PR-URL: https://github.com/nodejs/node/pull/32542
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

test: remove assert.doesNotThrow()

2018-02-16T15:53:47+00:00

There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

http2: use actual Timeout instances

2017-12-20T23:28:11+00:00

This makes `Http2Stream`s and `Http2Session`s use actual Timeout
objects in a [kTimeout] symbol property, rather than making the
stream/session itself a timer and appending properties to it directly.

PR-URL: https://github.com/nodejs/node/pull/17704
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski

http2: cleanup Http2Stream/Http2Session destroy

2017-12-18T18:19:21+00:00

PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Anatoli Papirovski 

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

doc: use American spellings per style guide

2017-12-07T00:52:31+00:00

PR-URL: https://github.com/nodejs/node/pull/17471
Reviewed-By: James M Snell 
Reviewed-By: Jon Moss 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca

http2: use 'close' event instead of 'streamClosed'

2017-11-28T18:30:39+00:00

PR-URL: https://github.com/nodejs/node/pull/17328
Fixes: https://github.com/nodejs/node/issues/15303
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Sebastiaan Deckers

http2: do not allow socket manipulation

2017-10-25T16:50:44+00:00

Because of the specific serialization and processing requirements
of HTTP/2, sockets should not be directly manipulated. This
forbids any interactions with destroy, emit, end, pause, read,
resume and write methods of the socket. It also redirects
setTimeout to session instead of socket.

PR-URL: https://github.com/nodejs/node/pull/16330
Fixes: https://github.com/nodejs/node/issues/16252
Refs: https://github.com/nodejs/node/pull/16211
Reviewed-By: James M Snell