delta/node-new.git/test/parallel/test-http2-compat-serverresponse-createpushresponse.js, branch cleanup-getnodeversion.py

errors: add more information in case of invalid callbacks

2019-04-04T10:51:03+00:00

This adds the actual callback that is passed through to the error
message in case an ERR_INVALID_CALLBACK error is thrown.

PR-URL: https://github.com/nodejs/node/pull/27048
Reviewed-By: Luigi Pinca 
Reviewed-By: Yongsheng Zhang

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

http2: refactor how trailers are done

2018-04-16T16:53:32+00:00

Rather than an option, introduce a method and an event...

```js
server.on('stream', (stream) => {
  stream.respond(undefined, { waitForTrailers: true });
  stream.on('wantTrailers', () => {
    stream.sendTrailers({ abc: 'xyz'});
  });
  stream.end('hello world');
});
```

This is a breaking change in the API such that the prior
`options.getTrailers` is no longer supported at all.
Ordinarily this would be semver-major and require a
deprecation but the http2 stuff is still experimental.

PR-URL: https://github.com/nodejs/node/pull/19959
Reviewed-By: Yuta Hiroto 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina

test,benchmark,doc: enable dot-notation rule

2018-02-16T18:37:43+00:00

This enables the eslint dot-notation rule for all code instead of
only in /lib.

PR-URL: https://github.com/nodejs/node/pull/18749
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Matheus Marchini

http2: cleanup Http2Stream/Http2Session destroy

2017-12-18T18:19:21+00:00

PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Anatoli Papirovski 

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

http2: make --expose-http2 flag a non-op

2017-09-28T05:01:06+00:00

Make the `http2` module always available.
The `--expose-http2` cli flag is made a non-op

PR-URL: https://github.com/nodejs/node/pull/15535
Reviewed-By: Matteo Collina 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Ruben Bridgewater

http2: small fixes to compatibility layer

2017-09-21T07:21:53+00:00

Expand argument validation through compat API, adjust behaviour
of response.end to not throw if stream already closed to match
http1, adjust behaviour of writeContinue to not throw if stream
already closed and other very small tweaks. Add tests for added
and fixed behaviour. Add tests for edge case behaviours of
setTimeout, createPushResponse, destroy, end and trailers.

PR-URL: https://github.com/nodejs/node/pull/15473
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Minwoo Jung

test: add crypto check to http2 tests

2017-08-08T22:30:46+00:00

When building --without-ssl and running the tests some of the http2 test
fail with the following error message:

internal/util.js:82
    throw new errors.Error('ERR_NO_CRYPTO');
    ^

Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
    at Object.assertCrypto (internal/util.js:82:11)
    at internal/http2/core.js:5:26
    at NativeModule.compile (bootstrap_node.js:586:7)
    at NativeModule.require (bootstrap_node.js:531:18)
    at http2.js:17:5
    at NativeModule.compile (bootstrap_node.js:586:7)
    at Function.NativeModule.require (bootstrap_node.js:531:18)
    at Function.Module._load (module.js:449:25)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)

This commit adds hasCrypto checks and skips the tests if there is no
crypto support.

PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

http2: doc and fixes to the Compatibility API

2017-08-04T19:56:50+00:00

PR-URL: https://github.com/nodejs/node/pull/14239
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matteo Collina

http2: add tests and benchmarks

2017-08-04T19:55:58+00:00

PR-URL: https://github.com/nodejs/node/pull/14239
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matteo Collina