delta/node-new.git/test/parallel/test-http-write-empty-string.js, branch cleanup-getnodeversion.py

test: refactor test-http-write-empty-string to use arrow functions

2018-11-21T18:41:54+00:00

In `test/parallel/test-http-write-empty-string.js`, callbacks use
anonymous closure functions. Replace them with arrow functions.

PR-URL: https://github.com/nodejs/node/pull/24483
Reviewed-By: Gireesh Punathil 
Reviewed-By: Ruben Bridgewater

test: fix strictEqual() argument order

2018-10-23T05:12:36+00:00

PR-URL: https://github.com/nodejs/node/pull/23768
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Michaël Zasso

lib,src: fix consistent spacing inside braces

2017-07-21T19:13:47+00:00

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: Timothy Gu 
Reviewed-By: James M Snell

test: reduce string concatenations

2017-05-05T14:39:05+00:00

PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann 
Reviewed-By: Gibson Fahnestock

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: s/assert.equal/assert.strictEqual/

2017-01-11T14:19:26+00:00

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Michaël Zasso 
Reviewed-By: Teddy Katz

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: use const for all require() calls

2017-01-02T23:28:18+00:00

PR-URL: https://github.com/nodejs/node/pull/10550
Reviewed-By: Rich Trott

test: use mustCall() for simple flow tracking

2016-07-18T21:14:16+00:00

Many of the tests use variables to track when callback functions
are invoked or events are emitted. These variables are then
asserted on process exit. This commit replaces this pattern in
straightforward cases with common.mustCall(). This makes the
tests easier to reason about, leads to a net reduction in lines
of code, and uncovered a few bugs in tests. This commit also
replaces some callbacks that should never be called with
common.fail().

PR-URL: https://github.com/nodejs/node/pull/7753
Reviewed-By: Wyatt Preul 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ben Noordhuis

test: use random ports where possible

2016-06-11T02:30:55+00:00

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Rod Vagg