delta/node-new.git/test/parallel/test-http-parser.js, branch devsnek-patch-1

async_hooks: fixup do not reuse HTTPParser

2019-05-03T14:02:55+00:00

Fix some issues introduced/not fixed via
https://github.com/nodejs/node/pull/25094:
* Init hook is not emitted for a reused HTTPParser
* HTTPParser was still used as resource in init hook
* type used in init hook was always HTTPINCOMINGMESSAGE even for client
requests
* some tests have not been adapted to new resource names

With this change the async hooks init event is emitted during a call
to Initialize() as the type and resource object is available at this
time. As a result Initialize() must be called now which could be seen
as breaking change even HTTPParser is not part of documented API.

It was needed to put the ClientRequest instance into a wrapper object
instead passing it directly as async resource otherwise
test-domain-multi fails. I think this is because adding an EventEmitter
to a Domain adds a property 'domain' and the presence of this changes
the context propagation in domains.

Besides that tests still refering to resource HTTPParser have been
updated/improved.

Fixes: https://github.com/nodejs/node/issues/27467
Fixes: https://github.com/nodejs/node/issues/26961
Refs: https://github.com/nodejs/node/pull/25094

PR-URL: https://github.com/nodejs/node/pull/27477
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

src: do not reuse async resource in http parsers

2019-04-22T18:51:46+00:00

Change resource being used, previously HTTParser was being reused.
We are now using IncomingMessage and ClientRequest objects.  The goal
here is to make the async resource unique for each async operatio

Refs: https://github.com/nodejs/node/pull/24330
Refs: https://github.com/nodejs/diagnostics/issues/248
Refs: https://github.com/nodejs/node/pull/21313

Co-authored-by: Matheus Marchini 

PR-URL: https://github.com/nodejs/node/pull/25094
Reviewed-By: Matteo Collina 
Reviewed-By: Benedikt Meurer 
Reviewed-By: Anna Henningsen

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

http: make parser choice a runtime flag

2018-12-06T04:21:36+00:00

Add a `--http-parser=llhttp` vs `--http-parser=traditional`
command line switch, to make testing and comparing the new
llhttp-based implementation easier.

PR-URL: https://github.com/nodejs/node/pull/24739
Refs: https://github.com/nodejs/node/issues/24730
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Fedor Indutny 
Reviewed-By: Gus Caplan 
Reviewed-By: Matheus Marchini 
Reviewed-By: Matteo Collina 
Reviewed-By: Ali Ijaz Sheikh

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10T06:45:56+00:00

This adds missing async_hooks destroy calls for sockets (in
_http_agent.js) and HTTP parsers. We need to emit a destroy in
AsyncWrap#AsyncReset before assigning a new async_id when the instance
has already been in use and is being recycled, because in that case, we
have already emitted an init for the "old" async_id.

This also removes a duplicated init call for HTTP parser: Each time a
new parser was created, AsyncReset was being called via the C++ Parser
class constructor (super constructor AsyncWrap) and also via
Parser::Reinitialize.

PR-URL: https://github.com/nodejs/node/pull/23272
Fixes: https://github.com/nodejs/node/issues/19859
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

http: move process.binding('http_parser') to internalBinding

2018-08-18T20:01:21+00:00

Refs: https://github.com/nodejs/node/issues/22160

PR-URL: https://github.com/nodejs/node/pull/22329
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Jon Moss 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

test: fix assert.throws error in test-http-parser

2018-03-29T04:28:35+00:00

The third argument of `assert.throws()` is a message that is used by the
AssertionError, not the message to check in the thrown error. It appears
that there is an assert.throws() in test-http-parser that expects the
latter behavior. Rewrite the call to check the error message. Even if
this wasn't a mistake, this change results in a more robust check.

PR-URL: https://github.com/nodejs/node/pull/19626
Reviewed-By: Daniel Bevenius 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell

test: refactor test-http-parser

2018-01-19T11:58:31+00:00

Use common's mustCall (for some reason was implementing its own?), and
other small fixes.

PR-URL: https://github.com/nodejs/node/pull/18219
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater

test: remove unused arguments from function

2017-08-23T09:24:51+00:00

Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: https://github.com/nodejs/node/pull/14931
Reviewed-By: Rich Trott 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Refael Ackermann 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Alexey Orlenko

test: refactor test-http-parser.js

2017-07-27T16:22:28+00:00

* eliminate CRLF identifier, reducing string concatenation
* adjust indentation for stricter ESLint 4.x indentation linting

PR-URL: https://github.com/nodejs/node/pull/14431
Reviewed-By: Refael Ackermann 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trevor Norris