delta/node-new.git/test/parallel/test-http-byteswritten.js, branch cleanup-getnodeversion.py

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: use repeat() instead of new Array().join()

2017-02-02T04:06:04+00:00

The usage of `new Array(length + 1).join(str)` is strange.
Change to `str.repeat(length)` is more clearly.

PR-URL: https://github.com/nodejs/node/pull/11071
Reviewed-By: Luigi Pinca 
Reviewed-By: Evan Lucas 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Italo A. Casas

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: use const for all require() calls

2017-01-02T23:28:18+00:00

PR-URL: https://github.com/nodejs/node/pull/10550
Reviewed-By: Rich Trott

tools: add eslint rule prefer-assert-methods

2016-09-20T23:35:39+00:00

PR-URL: https://github.com/nodejs/node/pull/8622
Reviewed-By: James M Snell 
Reviewed-By: Yorkie Liu 
Reviewed-By: Jackson Tian 
Reviewed-By: Johan Bergström 
Reviewed-By: Rich Trott 
Reviewed-By: Teddy Katz

test: use mustCall() for simple flow tracking

2016-07-18T21:14:16+00:00

Many of the tests use variables to track when callback functions
are invoked or events are emitted. These variables are then
asserted on process exit. This commit replaces this pattern in
straightforward cases with common.mustCall(). This makes the
tests easier to reason about, leads to a net reduction in lines
of code, and uncovered a few bugs in tests. This commit also
replaces some callbacks that should never be called with
common.fail().

PR-URL: https://github.com/nodejs/node/pull/7753
Reviewed-By: Wyatt Preul 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ben Noordhuis

test: use random ports where possible

2016-06-11T02:30:55+00:00

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Rod Vagg

buffer: add .from(), .alloc() and .allocUnsafe()

2016-03-16T15:34:02+00:00

Several changes:

* Soft-Deprecate Buffer() constructors
* Add `Buffer.from()`, `Buffer.alloc()`, and `Buffer.allocUnsafe()`
* Add `--zero-fill-buffers` command line option
* Add byteOffset and length to `new Buffer(arrayBuffer)` constructor
* buffer.fill('') previously had no effect, now zero-fills
* Update the docs

PR-URL: https://github.com/nodejs/node/pull/4682
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Stephen Belanger

tools: lint for spacing around unary operators

2016-02-04T18:56:17+00:00

Enable `space-unary-ops` in `.eslintrc`. This prohibits things like:

    i ++        // use `i++` instead
    typeof(foo) // use `typeof foo` or `typeof (foo)` instead

Ref: https://github.com/nodejs/node/pull/4772#discussion_r51732299
PR-URL: https://github.com/nodejs/node/pull/5063
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: Roman Reiss 
Reviewed-By: James M Snell

test: remove unused variables form http tests

2015-12-29T00:17:24+00:00

The http tests seem especially prone to including unused variables.
This change removes them.

PR-URL: https://github.com/nodejs/node/pull/4422
Reviewed-By: Johan Bergström