delta/node-new.git/test/parallel/test-fs-utimes.js, branch Remove-Python-3-tests

fs: validate fds as int32s

2019-08-07T20:27:55+00:00

This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: https://github.com/nodejs/node/pull/28984
Fixes: https://github.com/nodejs/node/issues/28980
Reviewed-By: Michaël Zasso 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

test: rewrite fs {f}utimes test file

2019-01-28T23:14:40+00:00

Previously this test silently swallowed some errors.

Refactored to use `common.mustCall()` & `assert()`s.

Also, this adds a couple of extra error-checking cases.

PR-URL: https://github.com/nodejs/node/pull/25656
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

test: remove unnecessary linter comment

2018-12-15T17:10:49+00:00

Some would say it's the linter's job to determine what
looks right.

PR-URL: https://github.com/nodejs/node/pull/25013
Reviewed-By: Richard Lau 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: Roman Reiss

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

test: avoid running fsync on directory on AIX

2018-06-22T15:30:26+00:00

On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: https://github.com/nodejs/node/pull/21298
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell

fs: fix error handling

2018-03-25T00:45:40+00:00

Right now there are multiple cases where the validated entry would
not be returned or a wrong error is thrown. This fixes both cases.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

lib,test: minor refactoring

2018-03-25T00:45:38+00:00

This refactors a couple tests to have upper case first characters
in comments and to use `input` instead of `i`.
It also adds a few TODOs and rewrites a few lines to use default
arguments and to prevent function recreation when unnecessary.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

tools: enable eslint no-undef-init rule

2018-02-22T14:56:11+00:00

This also fixes the three entries that did not pass.

PR-URL: https://github.com/nodejs/node/pull/18831
Reviewed-By: Luigi Pinca 
Reviewed-By: Matheus Marchini 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Colin Ihrig