delta/node-new.git/test/parallel/test-dgram-error-message-address.js, branch Remove-Python-3-tests

test: replace indexOf with includes and startsWith

2017-07-02T21:36:39+00:00

PR-URL: https://github.com/nodejs/node/pull/13852
Refs: https://github.com/nodejs/node/issues/12586
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: Vse Mozhet Byt

test: reduce string concatenations

2017-05-05T14:39:05+00:00

PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann 
Reviewed-By: Gibson Fahnestock

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: add common.mustNotCall()

2017-02-06T19:07:55+00:00

This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: https://github.com/nodejs/node/pull/11152
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Yuta Hiroto

test: cleanup test-dgram-error-message-address

2016-11-28T07:22:52+00:00

* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: https://github.com/nodejs/node/issues/8925
PR-URL: https://github.com/nodejs/node/pull/8938
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso

test: use random ports where possible

2016-06-11T02:30:55+00:00

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Rod Vagg

test: remove unused vars from parallel tests

2016-01-04T22:20:03+00:00

Remove all remaining unused variables from tests in test/parallel.

PR-URL: https://github.com/nodejs/node/pull/4511
Reviewed-By: James M Snell
Reviewed-By: Johan Bergström

test: wrap assert.fail when passed to callback

2015-10-24T21:42:41+00:00

Currently there are many instances where assert.fail is directly passed
to a callback for error handling. Unfortunately this will swallow the
error as it is the third argument of assert.fail that sets the message
not the first.

This commit adds a new function to test/common.js that simply wraps
assert.fail and calls it with the provided message.

Tip of the hat to @trott for pointing me in the direction of this.

PR-URL: https://github.com/nodejs/node/pull/3453
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott

test: enable linting for tests

2015-05-19T19:21:27+00:00

Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis

test: accept EPROTONOSUPPORT ipv6 error

2015-02-05T23:49:00+00:00

The IPv6 test in parallel/test-dgram-error-message-address may fail
when the host system has disabled IPv6, as is the case on our FreeBSD
machines.  The test already accepted EAFNOSUPPORT as of commit 5ba307a,
now make it accept EPROTONOSUPPORT as well.

I'm not exactly thrilled by the profusion of error codes but they are
all legitimate.

PR-URL: https://github.com/iojs/io.js/pull/733
Reviewed-By: Fedor Indutny