<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node-new.git/test/parallel/test-crypto-hash-stream-pipe.js, branch Remove-Python-3-tests</title>
<subtitle>github.com: nodejs/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/'/>
<entry>
<title>crypto: fix crash when calling digest after piping</title>
<updated>2019-06-18T16:42:48+00:00</updated>
<author>
<name>Tobias Nießen</name>
<email>tniessen@tnie.de</email>
</author>
<published>2019-06-16T09:26:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=fc50e6bcc81e4b34f4f3f3fe494b79200ae22efb'/>
<id>fc50e6bcc81e4b34f4f3f3fe494b79200ae22efb</id>
<content type='text'>
When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in
hash._flush, bypassing safeguards in the JavaScript layer. Calling
hash.digest causes EVP_DigestFinal_ex to be called again, resulting
in a segmentation fault in the SHA3 implementation of OpenSSL.

A relatively easy solution is to cache the result of calling
EVP_DigestFinal_ex until the Hash object is garbage collected.

PR-URL: https://github.com/nodejs/node/pull/28251
Fixes: https://github.com/nodejs/node/issues/28245
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in
hash._flush, bypassing safeguards in the JavaScript layer. Calling
hash.digest causes EVP_DigestFinal_ex to be called again, resulting
in a segmentation fault in the SHA3 implementation of OpenSSL.

A relatively easy solution is to cache the result of calling
EVP_DigestFinal_ex until the Hash object is garbage collected.

PR-URL: https://github.com/nodejs/node/pull/28251
Fixes: https://github.com/nodejs/node/issues/28245
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: simplify test skipping</title>
<updated>2017-07-04T09:41:49+00:00</updated>
<author>
<name>Vse Mozhet Byt</name>
<email>vsemozhetbyt@gmail.com</email>
</author>
<published>2017-06-30T23:29:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=2d2986ae72f2f5c63d95a94f05fa996d9f0609f1'/>
<id>2d2986ae72f2f5c63d95a94f05fa996d9f0609f1</id>
<content type='text'>
* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann &lt;refack@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann &lt;refack@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>meta: restore original copyright header</title>
<updated>2017-03-10T19:23:48+00:00</updated>
<author>
<name>James M Snell</name>
<email>jasnell@gmail.com</email>
</author>
<published>2017-01-03T21:16:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=98e54b0bd4854bdb3e2949d1b6b20d6777fb7cde'/>
<id>98e54b0bd4854bdb3e2949d1b6b20d6777fb7cde</id>
<content type='text'>
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.
</pre>
</div>
</content>
</entry>
<entry>
<title>test: refactor test-crypto-hash-stream-pipe</title>
<updated>2016-12-04T18:48:34+00:00</updated>
<author>
<name>Matt Wilson</name>
<email>matt.wilson@creditcards.com</email>
</author>
<published>2016-12-01T18:07:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=c0c67c953ffa2733d7d638d2ef586c04fc699cf0'/>
<id>c0c67c953ffa2733d7d638d2ef586c04fc699cf0</id>
<content type='text'>
Change var to const.

PR-URL: https://github.com/nodejs/node/pull/10055
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
Reviewed-By: Santiago Gimeno &lt;santiago.gimeno@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change var to const.

PR-URL: https://github.com/nodejs/node/pull/10055
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
Reviewed-By: Santiago Gimeno &lt;santiago.gimeno@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: crypto-hash-stream-pipe use strict equal</title>
<updated>2016-12-04T18:45:46+00:00</updated>
<author>
<name>Mitchell Stoutin</name>
<email>mitchell.stoutin@gmail.com</email>
</author>
<published>2016-12-01T16:28:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=1a83b194b3784a9df5ce8d89917a19e3a83f8451'/>
<id>1a83b194b3784a9df5ce8d89917a19e3a83f8451</id>
<content type='text'>
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: https://github.com/nodejs/node/pull/9935
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: https://github.com/nodejs/node/pull/9935
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: use mustCall() for simple flow tracking</title>
<updated>2016-07-18T21:14:16+00:00</updated>
<author>
<name>cjihrig</name>
<email>cjihrig@gmail.com</email>
</author>
<published>2016-07-15T19:43:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=04b4d15b396a7befea31dbfec89f69ff71dc71ca'/>
<id>04b4d15b396a7befea31dbfec89f69ff71dc71ca</id>
<content type='text'>
Many of the tests use variables to track when callback functions
are invoked or events are emitted. These variables are then
asserted on process exit. This commit replaces this pattern in
straightforward cases with common.mustCall(). This makes the
tests easier to reason about, leads to a net reduction in lines
of code, and uncovered a few bugs in tests. This commit also
replaces some callbacks that should never be called with
common.fail().

PR-URL: https://github.com/nodejs/node/pull/7753
Reviewed-By: Wyatt Preul &lt;wpreul@gmail.com&gt;
Reviewed-By: Minwoo Jung &lt;jmwsoft@gmail.com&gt;
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Many of the tests use variables to track when callback functions
are invoked or events are emitted. These variables are then
asserted on process exit. This commit replaces this pattern in
straightforward cases with common.mustCall(). This makes the
tests easier to reason about, leads to a net reduction in lines
of code, and uncovered a few bugs in tests. This commit also
replaces some callbacks that should never be called with
common.fail().

PR-URL: https://github.com/nodejs/node/pull/7753
Reviewed-By: Wyatt Preul &lt;wpreul@gmail.com&gt;
Reviewed-By: Minwoo Jung &lt;jmwsoft@gmail.com&gt;
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: abstract skip functionality to common</title>
<updated>2016-05-12T20:43:35+00:00</updated>
<author>
<name>Jeremiah Senkpiel</name>
<email>fishrock123@rocketmail.com</email>
</author>
<published>2016-05-11T19:34:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=52bae222a3a8480b2b30d8dc4629b64a284410d4'/>
<id>52bae222a3a8480b2b30d8dc4629b64a284410d4</id>
<content type='text'>
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

PR-URL: https://github.com/nodejs/node/pull/6697
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Santiago Gimeno &lt;santiago.gimeno@gmail.com&gt;
Reviewed-By: Fedor Indutny &lt;fedor.indutny@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

PR-URL: https://github.com/nodejs/node/pull/6697
Reviewed-By: Rich Trott &lt;rtrott@gmail.com&gt;
Reviewed-By: Santiago Gimeno &lt;santiago.gimeno@gmail.com&gt;
Reviewed-By: Fedor Indutny &lt;fedor.indutny@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: changing process.exit to return while skipping tests</title>
<updated>2015-07-20T10:20:42+00:00</updated>
<author>
<name>Sakthipriyan Vairamani</name>
<email>thechargingvolcano@gmail.com</email>
</author>
<published>2015-07-07T15:25:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=79c865a53feef1828d8c93e953acbeb01ee2cb74'/>
<id>79c865a53feef1828d8c93e953acbeb01ee2cb74</id>
<content type='text'>
This patch uses `return` statement to skip the test instead of using
`process.exit` call.

PR-URL: https://github.com/nodejs/io.js/pull/2109
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
Reviewed-By: Johan Bergström &lt;bugs@bergstroem.nu&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch uses `return` statement to skip the test instead of using
`process.exit` call.

PR-URL: https://github.com/nodejs/io.js/pull/2109
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
Reviewed-By: Johan Bergström &lt;bugs@bergstroem.nu&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: enable linting for tests</title>
<updated>2015-05-19T19:21:27+00:00</updated>
<author>
<name>Roman Reiss</name>
<email>me@silverwind.io</email>
</author>
<published>2015-05-19T11:00:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=f29762f4dd5811464684f820286f1c90a694bdff'/>
<id>f29762f4dd5811464684f820286f1c90a694bdff</id>
<content type='text'>
Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test: refactor all tests that depends on crypto</title>
<updated>2015-03-05T01:31:41+00:00</updated>
<author>
<name>Johan Bergström</name>
<email>bugs@bergstroem.nu</email>
</author>
<published>2015-03-04T01:11:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=671fbd5a9de03c5ede968ef6c6b365965a546a55'/>
<id>671fbd5a9de03c5ede968ef6c6b365965a546a55</id>
<content type='text'>
we had a few ways versions of looking for support before executing a test. this
commit unifies them as well as add the check for all tests that previously
lacked them. found by running `./configure --without-ssl &amp;&amp; make test`. also,
produce tap skip output if the test is skipped.

PR-URL: https://github.com/iojs/io.js/pull/1049
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
Reviewed-By: Shigeki Ohtsu &lt;ohtsu@iij.ad.jp&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
we had a few ways versions of looking for support before executing a test. this
commit unifies them as well as add the check for all tests that previously
lacked them. found by running `./configure --without-ssl &amp;&amp; make test`. also,
produce tap skip output if the test is skipped.

PR-URL: https://github.com/iojs/io.js/pull/1049
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
Reviewed-By: Shigeki Ohtsu &lt;ohtsu@iij.ad.jp&gt;
</pre>
</div>
</content>
</entry>
</feed>
